Move EffectiveAreas and ThreadSafeFunctor classes out of EgammaTools

[guitargeek]

Updated PR description after sign-off:

1. Move EffectiveAreas and ConversionTools from RecoEgamma/EgammaTools into new package CommonTools/Egamma. This new package should have only minimal dependencies (DataFormats and FWCore) and the idea is that non-reco subsystems like NanoAOD or DQM can use these common EgammaTools without inheriting many Reco dependencies.
2. Moved the former ThreadSafeStringCut class from RecoEgamma/EgammaTools to CommonTools/Utils, generalized it and renamed it to ThreadSafeFunctor
3. MVAVariableManager was refactored a tiny bit to make it theoretically independent from the rest of RecoEgamma/EgammaTools

Original PR description:

The only RecoEgamma library that is used outside the RecoEgamma subsystem itself is RecoEgamma/EgammaTools, mostly for the ConversionTools and the EffectiveAreas helper class. Unfortunately, this comes with a big party of reco-dependencies, which is not desirable. The EffectiveAreas helper class for example only depends on FWCore/Utilites, so all these reco dependencies from local calo and ecal reconstruction are not needed. What bothers me most is that NanoAOD inherits all these low-level reco dependencies like RecoLocalCalo/HGCalRecAlgos just for using the EffectiveAreas.

To solve this issue, I suggest to move the EffectiveAreas class to CommonTools/Utils. That package also only depends on FWCore, and all the users of EffectiveAreas already depend on it anyway. While at it, I moved the former ThreadSafeStringCut class from RecoEgamma/EgammaTools to CommonTools/Utils as well, generalized it and renamed it to ThreadSafeFunctor. Finally, the MVAVariableManager was also refactored a tiny bit to make it theoretically independent from the rest of RecoEgamma/EgammaTools too.

Let me know what you think, and if you agree that CommonTools/Utils is the right packaged to move these classes into.

PR validation:

CMSSW compiles and local matrix tests pass.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29832/15366

• This PR adds an extra 64KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CommonTools/Utils
DQMOffline/Lumi
EgammaAnalysis/ElectronTools
PhysicsTools/NanoAOD
RecoEgamma/EgammaTools
RecoEgamma/ElectronIdentification
RecoEgamma/PhotonIdentification
Validation/RecoEgamma

@perrotta, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fgolf, @fioriNTU, @slava77, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@Sam-Harper, @makortel, @jainshilpi, @lgray, @sobhatta, @afiqaize, @gpetruc, @varuns23, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6291/console Started: 2020/05/14 10:48

[cmsbuild]

-1

Tested at: 0900ed4

CMSSW: CMSSW_11_1_X_2020-05-13-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2afcd2/6291/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following workflows:
136.88811 step2

runTheMatrix-results/136.88811_RunJetHT2018D_reminiaodUL+RunJetHT2018D_reminiaodUL+REMINIAOD_data2018UL+HARVEST2018_REMINIAOD_data2018UL/step2_RunJetHT2018D_reminiaodUL+RunJetHT2018D_reminiaodUL+REMINIAOD_data2018UL+HARVEST2018_REMINIAOD_data2018UL.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[perrotta]

please test with #29826

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) #29826
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6298/console Started: 2020/05/14 12:40

[jfernan2]

+1

[peruzzim]

+xpog
for the technical changes in PhysicsTools/NanoAOD

[guitargeek]

Hi @slava77, thanks for the sign-off, I updated the PR description.

[slava77]

we are still missing PDMV and L1 signatures.

[chayanit]

+1

[silviodonato]

do you have any comments @rekovic ?

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1