-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DetectorDescription FilteredView: remove debugging printouts #29623
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29623/14990
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: DetectorDescription/DDCMS @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test @bsunanda FYI |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
Thanks, @fabiocos ! |
Comparison is ready Comparison Summary:
|
+1 |
PR description:
In the
DetectorDescription FilteredView
methods about rotation there are some debuggingLogVerbatim
instructions, partially printing the rotation matrix, which were overlooked in the code at the time of the integration (by me as a release manager). They turn to be quite annoying while enabling Info/Verbatim level verbosity for development/debugging. I suggest to remove them. Alternatively they could be downgraded toLogDebug
if deemed still necessary.PR validation:
Code compiles and unit tests run.