Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUPPI tune v14 [10_6_X] #29601

Merged
merged 1 commit into from
May 14, 2020
Merged

Conversation

ahinzmann
Copy link
Contributor

PR description:

Switch to PUPPI v14 for UL-re-MiniAOD.

Also update customizer function for PUPPI tune V14 for JME-extended-NanoAODs for UL.

PR validation:

Does not change defaults.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport from #29600 to 10_6 to include into UL-reminiAOD.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 30, 2020

A new Pull Request was created by @ahinzmann for CMSSW_10_6_X.

It involves the following packages:

CommonTools/PileupAlgos

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @riga, @jdolen, @gkasieczka, @hatakeyamak, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

backport of #29600

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6005/console Started: 2020/05/05 11:35

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+1
Tested at: e76e650
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f7bda/6005/summary.html
CMSSW: CMSSW_10_6_X_2020-05-04-2300
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f7bda/6005/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 32
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211958
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@perrotta
Copy link
Contributor

+1

  • Puppi tune v14 is made available, and it can be enabled by using the run2_miniAOD_devel modifier
  • Defaults are not touched: jenkins tests pass and show no differences wrt baseline, as expected

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b60fd1b into cms-sw:CMSSW_10_6_X May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants