[LLVM10] Calibration fix clang warnings

[mrodozov]

PR description:

Fix clang 10 warnings

PR validation:

Builds without warnings with CLANG IB

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29594/14922

• This PR adds an extra 56KB to repository

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5915/console Started: 2020/04/29 23:41

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

CalibCalorimetry/EcalTPGTools
CalibFormats/SiStripObjects
CalibPPS/ESProducers
CalibTracker/SiStripCommon
CalibTracker/SiStripESProducers
Calibration/HcalCalibAlgos

@benkrikler, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@echabert, @forthommel, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @argiro, @mverzett, @mmusich, @threus this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: adcb0a1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3df0c/5915/summary.html
CMSSW: CMSSW_11_1_X_2020-04-29-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3df0c/5915/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2696435
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2696114
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[pohsun]

+1

[silviodonato]

Kind reminder @rekovic

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1