-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Run 3 beam pipe + Minor update of Phase 2 beam pipe #29589
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29589/14915
|
A new Pull Request was created by @ghugo83 for master. It involves the following packages: Geometry/CMSCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Differences are expected in Phase-2 WFs. |
+1 |
+1 |
Comparison job queued. |
Shall we merge this in 11_1_0_pre7? |
Hi - Could @ghugo83 add in the title that the Phase2 BP is also modified ? Thanks |
@silviodonato , yes, we need this asap for Run-3. This PR is an addition of two files, which are not used so far in any testing WF, so it is absolutely safe. |
Comparison is ready Comparison Summary:
|
+upgrade |
+1 @cvuosalo already approved this PR |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Also includes minor fix in Phase 2 BP.