Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a TrackerDTCProducer input tag in SLHCUpgradeSimulations/Geometry unit test #29476

Closed

Conversation

silviodonato
Copy link
Contributor

This is a trivial way to solve #29474.
I would prefer the L1T experts fix L1Trigger/TrackerDTC/src/Settings.cc to avoid this kind of error.
Please note that special InputTag such as @currentProcess does not work because of Settings::checkConfiguration() in L1Trigger/TrackerDTC/src/Settings.cc

PR validation:

cmsRun SLHCUpgradeSimulations/Geometry/test/phase2_digi_reco_pixelntuple_cfg.py

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29476/14680

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

SLHCUpgradeSimulations/Geometry

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

another PR will arrive from @tschuh see #29474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants