Phase2-hgx234 Transfer the constants for HGCal and also HGCalTB for DDD/DD4Hep

[bsunanda]

PR description:

Transfer the constants in HGCalParameters from the XML files for HGCal as well as HGCal TB applications. With this the HGCal code can work for DDD as well as DD4Hep applications

PR validation:

Used standard runTheMatrix.py to do the tests

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29364/14464

• This PR adds an extra 40KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29364/14464/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29364/14464/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29364/14465

• This PR adds an extra 40KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5485/console Started: 2020/04/01 15:42

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 425804e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34de0f/5485/summary.html
CMSSW: CMSSW_11_1_X_2020-04-01-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34de0f/5485/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 31 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2692110
• DQMHistoTests: Total failures: 29
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2691762
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[bsunanda]

There were some rounding errors in earlier versions. So some changes are expected - this version is surely better

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

There are 31 comparison differences. Are they due to this PR, or something else?

They are a known issue #29237

[silviodonato]

please test 23434.1001

[silviodonato]

please test workflow 23434.1001

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 23434.1001
  https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5528/console Started: 2020/04/04 16:55

[cmsbuild]

+1
Tested at: 8087bbb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34de0f/5528/summary.html
CMSSW: CMSSW_11_1_X_2020-04-04-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34de0f/5528/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-34de0f/23434.1001_TTbar_14TeV+RecoFullGlobalPU_TestOldDigi_2026D49PU+HARVESTFullGlobalPU_2026D49PU

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 24 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2692110
• DQMHistoTests: Total failures: 43
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2691748
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[silviodonato]

+1