Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport of LumiProducerFromBrilcalc for 10_6_X #29323

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

plujan
Copy link
Contributor

@plujan plujan commented Mar 27, 2020

This PR is a backport of LumiProducerFromBrilcalc (PR #29271 ) for 10_6_X. I've run the test job to verify that it runs correctly in 10_6_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2020

A new Pull Request was created by @plujan (Paul Lujan) for CMSSW_10_6_X.

It involves the following packages:

RecoLuminosity/LumiProducer

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5411/console Started: 2020/03/27 15:57

@cmsbuild
Copy link
Contributor

+1
Tested at: 254488c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4e224/5411/summary.html
CMSSW: CMSSW_10_6_X_2020-03-27-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4e224/5411/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 33
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211957
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@perrotta
Copy link
Contributor

backport of #29271

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8a0ea82 into cms-sw:CMSSW_10_6_X Mar 30, 2020
@plujan plujan deleted the LumiProducerFromBrilcalc10_6_X branch April 2, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants