-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GPU-capable workflow 11634.502 to the short matrix #29315
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29315/14391
|
A new Pull Request was created by @slava77 (Slava Krutelyov) for master. It involves the following packages: Configuration/PyReleaseValidation @chayanit, @cmsbuild, @wajidalikhan, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Currently, if the node has a GPU we can run on, we run the GPU version. (not sure if this answer is sufficient or you want to jump in the rabbit hole of "loading") |
apparently I do; but perhaps this is the case for setting up comparisons between different workflow outputs for the purpose of comparing GPU with non-GPU setup. |
The details are: both CPU and GPU modules will be constructed and all non-Event transitions run for both, Event transitions are run only for the "chosen case" (to be improved, #26438).
Forcing a GPU-capable workflow (with SwitchProducer) to run on CPU only is easy, just set |
If this begins to flip, we end up in the same situation as with AMD vs Intel comparisons used for the baseline, which was figured out by jenkins tools when we had these options. |
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
it looks like this PR went in too early. The on-demand variant is apparently .503, but it does not exist (yet) in the main release. |
in view of Patatrack integration, I propose to add a GPU-capable workflow to the short matrix so that we have it in the baseline tests as well.
A node without a GPU will run this workflow with a CPU setup via a switch producer.
The extra matrix test takes about 10 mins.
@smuzaffar @makortel
Ideally, for the jenkins tests not enabled for GPU I'd expect that this workflow to not load the GPU version. Is this expected to be the case if incidentally the node actually has a GPU available?