Backport of PR #29083, #29159 and #29235 [TDC functionality fix]

[lwang046]

PR description:

Back port the previous fixes of TDC functionality to 11_0_2 for the 11_0_X MC production campaign

PR validation:

No new codes introduced other than the previous fixes

if this PR is a backport please specify the original PR and why you need to backport that PR:

#29083
#29159
#29235

[cmsbuild]

A new Pull Request was created by @lwang046 for CMSSW_11_0_X.

It involves the following packages:

EventFilter/HcalRawToDigi
SimCalorimetry/HcalSimAlgos

@perrotta, @cmsbuild, @civanch, @mdhildreth, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mariadalfonso, @rovere this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5394/console Started: 2020/03/26 13:17

[cmsbuild]

+1
Tested at: d7b2d76
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6b813/5394/summary.html
CMSSW: CMSSW_11_0_X_2020-03-26-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6b813/5394/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2793840
• DQMHistoTests: Total failures: 92
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2793407
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[slava77]

+1

for #29310 d7b2d76

• the reco part is from HCAL: Adding HB TDC packing switch #29159 and comes with just a switch added in EventFilter/HcalRawToDigi/plugins/HcalDigiToRawuHTR.cc, which has no effect in the default setup.
• jenkins tests pass and reco comparisons show no differences; however the (perhaps more complete?) comparisons show changes in HCAL TDC monitoring in MC like in https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_0_X_2020-03-26-1100+f6b813/35644/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/Hcal_DigiTask.html

[lwang046]

This change in DQM TDC monitoring is due to the exact same reason from #29235 as explained by Salavat: #29235 (comment)

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[srimanob]

@lwang046 @slava77 @civanch
Will this PR change the behaviour of HCAL simulation in 11_0? Thanks.

[slava77]

IIUC, the Sim* parts change the content of the HCAL digis in their tdc values.
However, the tdc values are not propagated yet in the higher level reco objects and is not saved in RECO/AOD.

[srimanob]

@slava77
Thanks for the clarification.

This PR will be needed for the next CMSSW_11_0 before special relvals can be injected,
https://its.cern.ch/jira/browse/PDMVRELVALS-73
@chayanit

[silviodonato]

+1
@slava77 Thanks for the clarification.