Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-compiling code triggered by EDM_ML_DEBUG flag #29283

Merged
merged 18 commits into from
Mar 31, 2020
Merged

Fix non-compiling code triggered by EDM_ML_DEBUG flag #29283

merged 18 commits into from
Mar 31, 2020

Conversation

fabiocos
Copy link
Contributor

PR description:

This PR addresses the failures discussed in #29250 . In several cases the fix looks obvious, in others I have done what looked to me a reasonable choice. I have the feeling that most of this code was not really tested (otherwise people would notice the problems) and it is unused since long time.

PR validation:

USER_CXXFLAGS="-g -D=EDM_ML_DEBUG" scram b --reset runs successfully.

fabiocos added 17 commits March 23, 2020 17:30
@fabiocos
Set proper LogTrace label for DQMOffline/Muon/src/TriggerMatchMonitor.cc
cce5926
@fabiocos
Fix range loop printout in DQMOffline/Trigger/src/HLTTauDQMPath.cc
e9a0471
@fabiocos
Fix range loop printout in Geometry/HcalTowerAlgo/src/HcalDDDGeometry…
be7b4c9 
…Loader.cc
@fabiocos
Fix regex print in DQMOffline/Trigger/plugins/HLTTauDQMOfflineSource.cc
a59b4f9
@fabiocos
Fix comparison threshold in BTL/ETL electronics sim printout
40c1050
@fabiocos
Fix DetId logDebug printout in Calibration/TkAlCaRecoProducers/plugin…
20aaaa3 
…s/CalibrationTrackSelectorFromDetIdList.cc
@fabiocos
Remove not working printout with unclear purpose in Calibration/Isola…
789f448 
…tedParticles/src/MatchingSimTrack.cc
@fabiocos
Fix std::pair LogDebug printout in SimG4Core/Geometry/src/DDG4Product…
9d1eb0d 
…ionCuts.cc
@fabiocos
Fix debug printout in SimG4CMS/HGCalTestBeam/plugins/HGCPassive.cc
03255cd
@fabiocos
Fix LogTrace label in DQM/MuonMonitor/plugins/CosmicMuonRecoAnalyzer.cc
3155cde
@fabiocos
Remove unused and not defined debug statement in CondFormats/SiPixelT…
ffbacec 
…ransient/src/SiPixelUtils.cc
@fabiocos
Fix LogDebug statement in RecoMTD/MeasurementDet/src/MTDDetLayerMeasu…
04c569f 
…rements.cc
@fabiocos
Fix LogDebug printout in DQM/SiStripMonitorClient/src/SiStripTrackerM…
197f9e6 
…apCreator.cc
@fabiocos
Fix LogDebug printout in Geometry/TrackerCommonData/plugins/dd4hep/DD…
bff18e8 
…TrackerRingAlgo.cc
@fabiocos
scram b code-format
a303f5b
@fabiocos
Add missing include for EDM_ML_DEBUG in RecoTracker/SiTrackerMRHTools…
4cc391f 
…/src/SimpleDAFHitCollector.cc
@fabiocos
Fix missing include in SimCalorimetry/EcalSimAlgos/src/EcalCoder.cc a…
6a6df83 
…nd SimTransport/PPSProtonTransport/src/ProtonTransport.cc
@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone Mar 24, 2020
@perrotta
Copy link
Contributor

+1

  • Technical fixes
  • Jenkins tests pass

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7b579/5359/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692493
  • DQMHistoTests: Total failures: 29
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2692145
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@civanch
Copy link
Contributor

civanch commented Mar 25, 2020

+1

@jfernan2
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor Author

@christopheralanwest @tlampen @ggovi @kpedro88 comments or suggestions?

@kpedro88
Copy link
Contributor

+upgrade
thanks for fixing these!

@tocheng
Copy link
Contributor

tocheng commented Mar 26, 2020

+1

@fabiocos
Copy link
Contributor Author

@ggovi the update to CondFormats looks trivial, as the removed variable is not even declared, likely a left-over of some very old development.

@silviodonato
Copy link
Contributor

merge
@ggovi nRecHitsUsedEdge_ is not even defined in SiPixelUtils

@cmsbuild cmsbuild merged commit 61ea698 into cms-sw:master Mar 31, 2020
@fabiocos fabiocos deleted the fc-fixlogdebug branch March 31, 2020 15:52
@fabiocos fabiocos mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved code-checks-approved comparison-available db-pending dqm-approved geometry-approved orp-approved pending-signatures reconstruction-approved requires-external simulation-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.
9 participants
@fabiocos @cmsbuild @silviodonato @cvuosalo @perrotta @civanch @jfernan2 @kpedro88 @tocheng