DQM: Fix broken plots by MuonTrackValidator

[schneiml]

PR description:

We got a report that in the 11_1_0_pre4 relvals, some Moun Validation plots appear completely black in the DQMGUI. This is due to NaNs in the bin limits, which are in turn due to (apparently) not idempotent code in BinLogX, called in booking to change the binning of the vs_pt plots, which is a problem with the introduction of edm::stream based DQMEDAnalyzer in pre4.

This issue can be fixed by moving the call to BinLogX into a booking callback. This fixes MuonTrackValidator, there is another BinLogX in another module that might have the same issue.

The issue was not spotted in #28813 for multiple reasons:

• The problem only appears when running multiple streams; therefore not in the normal PR tests.
• The relevant plots are probably never filled in the PR/IB tests. Basically not a problem, as this is a booking issue, but
• The bin-to-bin comparison tool only checks bin values, not axis data. @andrius-k promised an improvement to cover this in the future.

PR validation:

Tested multi-threaded using

runTheMatrix.py -l 11634.7 -t 8

The NaNs disappeared (for one random affected ME):

diff <(dqmdumpme.py 11634.7_*/DQM_*.root Muons/RecoMuonV/MuonTrack/tevMuons_picky/dzres_vs_pt) <(dqmdumpme.py base/11634.7_*/DQM_*.root Muons/RecoMuonV/MuonTrack/tevMuons_picky/dzres_vs_pt)
83c83
<         0., 1., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0.,
...
352,364c352,355
<         0., 0., 0., 0.]], dtype=float32), [(array([8.99999976e-01, 1.04997325e+00, 1.22493768e+00, 1.42905772e+00,
<        1.66719151e+00, 1.94500732e+00, 2.26911759e+00, 2.64723635e+00,
<        3.08836389e+00, 3.60300016e+00, 4.20339298e+00, 4.90383339e+00,
<        5.72099400e+00, 6.67432404e+00, 7.78651285e+00, 9.08403301e+00,
<        1.05977688e+01, 1.23637495e+01, 1.44240093e+01, 1.68275795e+01,
<        1.96316776e+01, 2.29030437e+01, 2.67195320e+01, 3.11719971e+01,
<        3.63664093e+01, 4.24264030e+01, 4.94962120e+01, 5.77441025e+01,
<        6.73664093e+01, 7.85921555e+01, 9.16884918e+01, 1.06967201e+02,
<        1.24791901e+02, 1.45586853e+02, 1.69847031e+02, 1.98149841e+02,
<        2.31168961e+02, 2.69690125e+02, 3.14630493e+02, 3.67059601e+02,
<        4.28225372e+02, 4.99583588e+02, 5.82832764e+02, 6.79954285e+02,
<        7.93259460e+02, 9.25445923e+02, 1.07965955e+03, 1.25957080e+03,
<        1.46946204e+03, 1.71432886e+03, 1.99999963e+03]), array([-0.05 , -0.049, -0.048, -0.047, -0.046, -0.045, -0.044, -0.043,
---
>         0., 0., 0., 0.]], dtype=float32), [(array([nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan,
>        nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan,
>        nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan,
>        nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan]), array([-0.05 , -0.049, -0.048, -0.047, -0.046, -0.045, -0.044, -0.043,

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29224/14248

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @schneiml (Marcel Schneider) for master.

It involves the following packages:

Validation/RecoMuon

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @calderona, @HuguesBrun, @Fedespring, @cericeci, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[schneiml]

please test

let's see if the tests pick this up. As outlined above, I expect they won't.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5248/console Started: 2020/03/18 12:24

[cmsbuild]

+1
Tested at: 653a21d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3bd3d/5248/summary.html
CMSSW: CMSSW_11_1_X_2020-03-17-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3bd3d/5248/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2692437
• DQMHistoTests: Total failures: 31
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2692087
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[schneiml]

I uploaded the output from my private test to a GUI: https://tinyurl.com/w892nvl
The formerly black plots are not black here.

[jfernan2]

+1
Muon people agreed on the fix

[jfernan2]

urgent

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[jfernan2]

type bugfix

[silviodonato]

+1