-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce SONIC core in CMSSW #29141
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29141/14067
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
assign heterogeneous (until the new packages get added to |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29141/14068
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages: HeterogeneousCore/SonicCore The following packages do not have a category, yet: HeterogeneousCore/SonicCore @makortel, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
(as I mentioned in person) I'm not super happy with the name "Sonic" because it is not very descriptive, but I don't have any better concise suggestions either, so to me it is good enough. |
The tests are being triggered in jenkins. |
The tests are being triggered in jenkins.
|
+1 |
Comparison is ready Comparison Summary:
|
please test for cc8_aarch64_gcc8 |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
+1 |
PR description:
This PR introduces the core classes for SONIC as a new package in the HeterogeneousCore subsystem. This code is ported from https://github.com/hls-fpga-machine-learning/SonicCMS. Unit tests are included (based on the Acquire tests for ExternalWork in
FWCore/Integration/test
).Documentation is provided in the package README, as well as in a presentation at the core software meeting.
This package will be supplemented by additional packages implementing concrete clients for different communication protocols as the needed externals become available. (A separate package for each communication protocol is foreseen in order to compartmentalize the different external dependencies.)
PR validation:
Unit tests run successfully.