Adding parameters needed for PUjetID 94X and 102X (backport to 106X) #29045

alefisico · 2020-02-26T13:14:26Z

PR description:

This is a backport from #28984 meant for UL campaigns.

FYI: @ahinzmann @lathomas @camclean @peruzzim @nurfikri89

cmsbuild · 2020-02-26T13:14:47Z

A new Pull Request was created by @alefisico (Alejandro Gomez Espinosa) for CMSSW_10_6_X.

It involves the following packages:

RecoJets/JetProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @ahinzmann, @jdamgov, @yslai, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Backported from Adding parameters needed for PUjetID 94X and 102X v2 #28984

slava77 · 2020-02-26T13:52:57Z

@cmsbuild please test

cmsbuild · 2020-02-26T13:53:21Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4893/console Started: 2020/02/26 14:58

perrotta · 2020-02-26T14:09:25Z

backport of #28984

cmsbuild · 2020-02-26T14:58:06Z

-1

Tested at: 87259ed

CMSSW: CMSSW_10_6_X_2020-02-26-1100
SCRAM_ARCH: slc7_amd64_gcc700
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-248a93/4893/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
136.8311 step2

runTheMatrix-results/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017/step2_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017.log

136.7611 step2

runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

140.56 step2

runTheMatrix-results/140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18/step2_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

136.788 step3

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step3_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log

135.4 step3

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM.log

136.85 step3

runTheMatrix-results/136.85_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM/step3_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

158.0 step3

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step3_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

11624.0 step3

runTheMatrix-results/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

20034.0 step3

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

21234.0 step3

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21.log

27434.0 step3

runTheMatrix-results/27434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35.log

29034.0 step3

runTheMatrix-results/29034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D41+RecoFullGlobal_2023D41+HARVESTFullGlobal_2023D41/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D41+RecoFullGlobal_2023D41+HARVESTFullGlobal_2023D41.log

250202.181 step4

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step4_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

cmsbuild · 2020-02-26T14:58:09Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

alefisico · 2020-02-26T14:59:33Z

tests are failing because they cannot find the files from there PR cms-data/RecoJets-JetProducers#10

mrodozov · 2020-02-26T16:19:57Z

the reference to this cms-data/RecoJets-JetProducers#10 is only available in master (i.e 11_1_X ).
So to have the reference, we have to backport it to 10_6 and 10_2

alefisico · 2020-02-26T17:06:24Z

Hi @mrodozov
sorry I am not familiar with backports in cms-data, there is something additional that I have to do?

mrodozov · 2020-02-26T17:09:10Z

please test with cms-data/RecoJets-JetProducers#10

mrodozov · 2020-02-26T17:10:57Z

although it's already merged, the data PR can still be used until we backport it to cmsdist 10_6

mrodozov · 2020-02-26T17:29:31Z

@alefisico if you see cms-sw/cmsdist#5607 and cms-sw/cmsdist#5606 that's how we put the reference for given data external for given release.

cmsbuild · 2020-02-28T09:29:00Z

Pull request #29045 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

cmsbuild · 2020-02-28T10:08:09Z

Pull request #29045 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

slava77 · 2020-03-02T14:23:00Z

@cmsbuild please test

cmsbuild · 2020-03-02T14:23:24Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4956/console Started: 2020/03/02 15:26

cmsbuild · 2020-03-02T15:54:33Z

+1
Tested at: 48fcaf0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-248a93/4956/summary.html
CMSSW: CMSSW_10_6_X_2020-03-02-1100
SCRAM_ARCH: slc7_amd64_gcc700

cmsbuild · 2020-03-02T15:54:37Z

Comparison job queued.

cmsbuild · 2020-03-02T17:25:09Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-248a93/4956/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3212324
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3211988
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

slava77 · 2020-03-02T23:21:08Z

+1

for #29045 48fcaf0

backport from Adding parameters needed for PUjetID 94X and 102X v2 #28984 is correct (accounting for the no-change compliance achieved using the run2_miniAOD_devel modifier)
jenkins tests pass and comparisons with the baseline show no differences

cmsbuild · 2020-03-02T23:21:26Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-03-03T08:25:53Z

+1

backporting PUID for 2017/2018

87259ed

cmsbuild added this to the CMSSW_10_6_X milestone Feb 26, 2020

cmsbuild added comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Feb 26, 2020

cmsbuild added tests-started and removed tests-pending labels Feb 26, 2020

cmsbuild added the backport-ok label Feb 26, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Feb 26, 2020

mrodozov mentioned this pull request Feb 26, 2020

[10.6.X] Backport of cms-data/RecoJets-JetProducers#10 on 10_6 cms-sw/cmsdist#5606

Merged

cmsbuild added comparison-pending and removed comparison-notrun tests-rejected labels Feb 26, 2020

cmsbuild added comparison-pending tests-pending and removed requires-external tests-approved labels Feb 28, 2020

adding modifier

48fcaf0

cmsbuild added tests-started and removed tests-pending labels Mar 2, 2020

cmsbuild added tests-approved and removed tests-started labels Mar 2, 2020

cmsbuild added comparison-available and removed comparison-pending labels Mar 2, 2020

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Mar 2, 2020

cmsbuild added orp-approved and removed orp-pending labels Mar 3, 2020

cmsbuild merged commit 5527453 into cms-sw:CMSSW_10_6_X Mar 3, 2020

slava77 mentioned this pull request Apr 2, 2020

fix miniaod_devel modifier use for pileupJetId.algos #29377

Merged

slava77 mentioned this pull request Apr 17, 2020

features for UL re-miniAOD in 10_6_X #27889

Closed

41 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding parameters needed for PUjetID 94X and 102X (backport to 106X) #29045

Adding parameters needed for PUjetID 94X and 102X (backport to 106X) #29045

alefisico commented Feb 26, 2020

cmsbuild commented Feb 26, 2020 •

edited

Loading

slava77 commented Feb 26, 2020

cmsbuild commented Feb 26, 2020 •

edited

Loading

perrotta commented Feb 26, 2020

cmsbuild commented Feb 26, 2020

cmsbuild commented Feb 26, 2020

alefisico commented Feb 26, 2020

mrodozov commented Feb 26, 2020 •

edited

Loading

alefisico commented Feb 26, 2020

mrodozov commented Feb 26, 2020

mrodozov commented Feb 26, 2020

mrodozov commented Feb 26, 2020

cmsbuild commented Feb 28, 2020

cmsbuild commented Feb 28, 2020

slava77 commented Mar 2, 2020

cmsbuild commented Mar 2, 2020 •

edited

Loading

cmsbuild commented Mar 2, 2020

cmsbuild commented Mar 2, 2020

cmsbuild commented Mar 2, 2020

slava77 commented Mar 2, 2020

cmsbuild commented Mar 2, 2020

silviodonato commented Mar 3, 2020

Adding parameters needed for PUjetID 94X and 102X (backport to 106X) #29045

Adding parameters needed for PUjetID 94X and 102X (backport to 106X) #29045

Conversation

alefisico commented Feb 26, 2020

PR description:

cmsbuild commented Feb 26, 2020 • edited Loading

slava77 commented Feb 26, 2020

cmsbuild commented Feb 26, 2020 • edited Loading

perrotta commented Feb 26, 2020

cmsbuild commented Feb 26, 2020

cmsbuild commented Feb 26, 2020

alefisico commented Feb 26, 2020

mrodozov commented Feb 26, 2020 • edited Loading

alefisico commented Feb 26, 2020

mrodozov commented Feb 26, 2020

mrodozov commented Feb 26, 2020

mrodozov commented Feb 26, 2020

cmsbuild commented Feb 28, 2020

cmsbuild commented Feb 28, 2020

slava77 commented Mar 2, 2020

cmsbuild commented Mar 2, 2020 • edited Loading

cmsbuild commented Mar 2, 2020

cmsbuild commented Mar 2, 2020

cmsbuild commented Mar 2, 2020

slava77 commented Mar 2, 2020

cmsbuild commented Mar 2, 2020

silviodonato commented Mar 3, 2020

cmsbuild commented Feb 26, 2020 •

edited

Loading

cmsbuild commented Feb 26, 2020 •

edited

Loading

mrodozov commented Feb 26, 2020 •

edited

Loading

cmsbuild commented Mar 2, 2020 •

edited

Loading