Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the gen filter for the run-II pMSSM effort - backport of #28201 #28998

Merged
merged 6 commits into from
Mar 2, 2020

Conversation

ssekmen
Copy link
Contributor

@ssekmen ssekmen commented Feb 19, 2020

PR description:

Backport of #28201.
Added a pythia8 gen-level filter to be used for the run-II pMSSM signal production.

PR validation:

Standard tests.

if this PR is a backport please specify the original PR and why you need to backport that PR:

#28201

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ssekmen (Sezen Sekmen) for CMSSW_9_4_X.

It involves the following packages:

GeneratorInterface/GenFilters

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@alberto-sanchez
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4840/console Started: 2020/02/24 15:53

@cmsbuild
Copy link
Contributor

+1
Tested at: f6c2d6d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99e92b/4840/summary.html
CMSSW: CMSSW_9_4_X_2020-02-23-0000
SCRAM_ARCH: slc6_amd64_gcc630

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99e92b/4840/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 105
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721226
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@silviodonato
Copy link
Contributor

Have you consider to make a backport to 10_6_X for UL?
Could you confirm you need this backport because you will produce 2017 MC samples in 9_4_X?

@ssekmen
Copy link
Contributor Author

ssekmen commented Mar 1, 2020

@silviodonato , this PR is needed for producing 2016 MC with 94X for the SUSY pMSSM study. We only backported it to 10_2_X (#28201). If necessary, we can also backport to 10_6_X.

@silviodonato
Copy link
Contributor

Do you have any objection @alberto-sanchez @agrohsje @efeyazgan @mkirsano @qliphy @SiewYan ?

@qliphy
Copy link
Contributor

qliphy commented Mar 2, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1
@ssekmen yes, please prepare also a PR for 10_6_X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants