Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumes migration2 #2896

Merged
merged 4 commits into from
Mar 18, 2014
Merged

Consumes migration2 #2896

merged 4 commits into from
Mar 18, 2014

Conversation

deguio
Copy link
Contributor

@deguio deguio commented Mar 17, 2014

consumes migration and code clean up

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @deguio for CMSSW_7_1_X.

Consumes migration2

It involves the following packages:

DQM/CSCMonitorModule
DQM/CastorMonitor
DQM/L1TMonitor
DQM/Physics
DQM/SiPixelMonitorRecHit
DQM/SiPixelMonitorTrack
DQM/SiStripCommissioningSources
DQM/SiStripMonitorClient
DQM/SiStripMonitorCluster
DQM/SiStripMonitorDigi
DQM/SiStripMonitorHardware
DQM/SiStripMonitorPedestals
DQM/SiStripMonitorTrack
DQM/TrackerCommon
DQM/TrackingMonitor
DQM/TrigXMonitor
DQMOffline/CalibMuon
DQMOffline/EGamma
DQMOffline/JetMET
HLTriggerOffline/Egamma
Validation/CaloTowers
Validation/EcalClusters
Validation/EcalDigis
Validation/EventGenerator
Validation/GlobalDigis
Validation/GlobalRecHits
Validation/HcalRecHits
Validation/MuonDTDigis
Validation/MuonHits
Validation/MuonIdentification
Validation/MuonRPCGeometry
Validation/RecoEgamma
Validation/RecoParticleFlow
Validation/RecoTrack
Validation/TrackerRecHits
Validation/TrackingMCTruth

@vciulli, @civanch, @Dr15Jones, @bendavid, @danduggan, @ianna, @thuer, @cmsbuild, @nclopezo, @mdhildreth, @deguio, @Degano, @ojeda, @rovere, @ktf can you please review it and eventually sign? Thanks.
@TaiSakuma, @GiacomoSguazzoni, @rovere, @argiro, @inugent, @nhanvtran, @cerati, @richard-cms, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor Author

deguio commented Mar 17, 2014

the first three commits should be in already. added an additional commit on top. if you have already approved the changes..... then sorry for the spam ;)

@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2896/558/summary.html

@cmsbuild
Copy link
Contributor

@vciulli
Copy link
Contributor

vciulli commented Mar 18, 2014

+1

@ianna
Copy link
Contributor

ianna commented Mar 18, 2014

+1

@deguio
Copy link
Contributor Author

deguio commented Mar 18, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Mar 18, 2014
@ktf ktf merged commit a29b121 into cms-sw:CMSSW_7_1_X Mar 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants