-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOCAL_DEBUG in MuonBaseNumber.cc restored #28921
Conversation
The code-checks are being triggered in jenkins. |
@fabiocos : as you requested |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28921/13716
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28921/13720
|
A new Pull Request was created by @slomeo (Sergio Lo Meo) for master. It involves the following packages: Geometry/MuonNumbering @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Remember to update the title of this PR. It should fix the unit test in Geometry/DTGeometryBuilder (#28796 (comment)) |
+1 |
Comparison job queued. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28921/13731
|
please test with 28875 |
Pull request #28921 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again. |
ping @cmsbuild |
please test with 28875 |
please test with #28875 |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Restored #ifdef LOCAL_DEBUG in MuonBaseNumber.cc as requested by @fabiocos