-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEM DQM updates - full GE1/1, backport to 11_0_X #28878
GEM DQM updates - full GE1/1, backport to 11_0_X #28878
Conversation
A new Pull Request was created by @quark2 for CMSSW_11_0_X. It involves the following packages: DQM/GEM @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
hold |
Pull request has been put on hold by @jfernan2 |
@quark2 Could you quote the number of the CMSSW_11_1_X PR in the description? |
@jfernan2 @quark2 @silviodonato this PR has been tested in the playback on top of CMSS_11_0_0_patch1, and it fixes the crash in the gem client. So, I think we can unhold this PR. Even if there are no actual data to process, empty GEM plots can be seen in the playback GUI: |
@silviodonato okay, I added |
unhold |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This backport PR to 11_0_X (from #28769) updates and extends the part of onlineDQM for GEM. The details are following:
Please see this to check more details, especially the visualization with DQM GUI (there is also an update for GEM part for onlineDQM GUI, which will be PRed soon)
PR validation:
Test are done and one can check again by
runTheMatrix
workflows@jshlee @watson-ij