Basic Rivet tests #28873

mseidel42 · 2020-02-05T17:12:17Z

PR description:

Adding basic tests to check Rivet correct functioning:

List analyses and check for a specific one
Generate events and run Rivet within CMSSW

PR validation:

Tests function as expected:

===== Test "test-rivet-list" ====
MC_GENERIC                  Generic MC testing analysis

---> test test-rivet-list succeeded
 
^^^^ End Test test-rivet-list ^^^^
Package GeneratorInterface/RivetInterface: Running test test-rivet-run
 
===== Test "test-rivet-run" ====
[CMSSW output]

---> test test-rivet-run succeeded
 
^^^^ End Test test-rivet-run ^^^^
>> Tests for package GeneratorInterface/RivetInterface ran.
>> Test sequence completed for CMSSW CMSSW_11_1_0_pre2
scram build runtests  21.32s user 10.35s system 86% cpu 36.726 total

cmsbuild · 2020-02-05T17:12:40Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-02-05T17:18:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28873/13642

This PR adds an extra 16KB to repository

cmsbuild · 2020-02-05T17:19:25Z

A new Pull Request was created by @intrepid42 (Markus Seidel) for master.

It involves the following packages:

GeneratorInterface/RivetInterface

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

qliphy · 2020-02-06T06:26:55Z

please test

cmsbuild · 2020-02-06T06:27:21Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4524/console Started: 2020/02/06 07:27

smuzaffar · 2020-02-06T07:25:58Z

GeneratorInterface/RivetInterface/test/test-rivet-list.sh

@@ -0,0 +1,3 @@
+#!/bin/sh


please use #!/bin/sh -e so that script exits at first error.

smuzaffar · 2020-02-06T07:26:03Z

GeneratorInterface/RivetInterface/test/test-rivet-run.sh

@@ -0,0 +1,3 @@
+#!/bin/sh


please use #!/bin/sh -e so that script exits at first error.

cmsbuild · 2020-02-06T07:38:16Z

+1
Tested at: 4e1d19e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b307b/4524/summary.html
CMSSW: CMSSW_11_1_X_2020-02-05-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-02-06T07:38:19Z

Comparison job queued.

cmsbuild · 2020-02-06T07:54:00Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-02-06T08:00:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28873/13647

This PR adds an extra 16KB to repository

cmsbuild · 2020-02-06T08:02:23Z

Pull request #28873 was updated. @SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please check and sign again.

qliphy · 2020-02-06T08:51:04Z

please test

cmsbuild · 2020-02-06T08:51:24Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4528/console Started: 2020/02/06 09:59

cmsbuild · 2020-02-06T09:07:38Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b307b/4524/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2698043
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2697696
DQMHistoTests: Total skipped: 346
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

cmsbuild · 2020-02-06T10:10:57Z

+1
Tested at: 08b90ac
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b307b/4528/summary.html
CMSSW: CMSSW_11_1_X_2020-02-05-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-02-06T10:11:01Z

Comparison job queued.

cmsbuild · 2020-02-06T11:45:53Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b307b/4528/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2698043
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2697696
DQMHistoTests: Total skipped: 346
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

qliphy · 2020-02-06T12:43:29Z

+1

cmsbuild · 2020-02-06T12:44:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

mseidel42 · 2020-02-06T13:42:57Z

Nice, the unit tests work :) https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b307b/4528/unitTests.log

silviodonato · 2020-02-07T15:33:34Z

+1

Basic Rivet tests

4e1d19e

cmsbuild added this to the CMSSW_11_1_X milestone Feb 5, 2020

cmsbuild added code-checks-pending comparison-pending generators-pending orp-pending pending-signatures tests-pending labels Feb 5, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 5, 2020

cmsbuild added tests-started and removed tests-pending labels Feb 6, 2020

smuzaffar reviewed Feb 6, 2020

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Feb 6, 2020

Use sh -e

08b90ac

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-approved labels Feb 6, 2020

cmsbuild added tests-started and removed tests-pending labels Feb 6, 2020

cmsbuild added comparison-available and removed comparison-pending labels Feb 6, 2020

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Feb 6, 2020

cmsbuild added comparison-available and removed comparison-pending labels Feb 6, 2020

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Feb 6, 2020

cmsbuild added orp-approved and removed orp-pending labels Feb 7, 2020

cmsbuild merged commit e946a97 into cms-sw:master Feb 7, 2020

cmsbuild mentioned this pull request Feb 7, 2020

ConditionFormats/Serialization: Update eos portable archive to work with boost 1.69.0+ #28893

Merged

silviodonato mentioned this pull request Feb 11, 2020

Rivet unit test fails with python3 #28919

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Basic Rivet tests #28873

Basic Rivet tests #28873

mseidel42 commented Feb 5, 2020

cmsbuild commented Feb 5, 2020

cmsbuild commented Feb 5, 2020

cmsbuild commented Feb 5, 2020

qliphy commented Feb 6, 2020

cmsbuild commented Feb 6, 2020 •

edited

Loading

smuzaffar Feb 6, 2020

smuzaffar Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

qliphy commented Feb 6, 2020

cmsbuild commented Feb 6, 2020 •

edited

Loading

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

qliphy commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

mseidel42 commented Feb 6, 2020

silviodonato commented Feb 7, 2020

Basic Rivet tests #28873

Basic Rivet tests #28873

Conversation

mseidel42 commented Feb 5, 2020

PR description:

PR validation:

cmsbuild commented Feb 5, 2020

cmsbuild commented Feb 5, 2020

cmsbuild commented Feb 5, 2020

qliphy commented Feb 6, 2020

cmsbuild commented Feb 6, 2020 • edited Loading

smuzaffar Feb 6, 2020

Choose a reason for hiding this comment

smuzaffar Feb 6, 2020

Choose a reason for hiding this comment

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

qliphy commented Feb 6, 2020

cmsbuild commented Feb 6, 2020 • edited Loading

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

qliphy commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

mseidel42 commented Feb 6, 2020

silviodonato commented Feb 7, 2020

cmsbuild commented Feb 6, 2020 •

edited

Loading

cmsbuild commented Feb 6, 2020 •

edited

Loading