Tracking DQM: fix multiple ME bookings for Track Seed Monitoring

[mmusich]

PR description:

This PR attempts to fix the issue reported at #28823 (comment).
The multiple booking of plots in the same folder done by several instances of TrackingMonitor:

TrackSeedMondetachedQuadStep
TrackSeedMondetachedTripletStep
TrackSeedMonhighPtTripletStep
TrackSeedMoninitialStep
TrackSeedMonjetCoreRegionalStep
TrackSeedMonlowPtQuadStep
TrackSeedMonlowPtTripletStep
TrackSeedMonmixedTripletStep
TrackSeedMonmuonSeededStepInOut
TrackSeedMonmuonSeededStepOutIn
TrackSeedMonpixelLessStep
TrackSeedMonpixelPairStep
TrackSeedMontobTecStep
TrackerCollisionSelected
TrackMonCommongeneralTracks

are now dispatched to several subfolders.
The redundant plots vs PU or vs GoodVtx that do not make sense per seeding type are switched off.

PR validation:

Basic integration tests have been run. Visual inspection of the output file looks compatible with expectations.
I also run the DQM bin-by-bin comparison tool on local files produced with wf 25202, but at the moment it does not make sense to me, so I am waiting for experts to debug it.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport and no backport is intended.
cc:

@mtosi @sroychow @arossi83

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28859/13617

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

DQM/TrackingMonitorSource

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @mtosi, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4482/console Started: 2020/02/03 19:19

[cmsbuild]

+1
Tested at: abde178
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e0799/4482/summary.html
CMSSW: CMSSW_11_1_X_2020-02-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e0799/4482/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2690188
• DQMHistoTests: Total failures: 49
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2689793
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 169.895 KiB( 33 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): 7.218 KiB Tracking/TrackParameters
• DQMHistoSizes: changed ( 10024.0,... ): 8.525 KiB Tracking/TrackParameters
• DQMHistoSizes: changed ( 20034.0,... ): 4.594 KiB Tracking/TrackParameters
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

hold
"I also run the DQM bin-by-bin comparison tool on local files produced with wf 25202, but at the moment it does not make sense to me, so I am waiting for experts to debug it."
@mmusich @jfernan2 Have you understood these results?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_1_X_2020-02-03-1100+8e0799/34941/dqm-histo-comparison-summary.html

[cmsbuild]

Pull request has been put on hold by @silviodonato
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[mmusich]

@silviodonato I do understand the results from the bot (which match the expectations). What I don't understand are the results using the tool locally on files produced by myself, but maybe I made a mistake in running it. It is not really essential for the PR given we have the central results now.

[jfernan2]

@silviodonato @mmusich we believe Marco took a wrong file for baseline in his manual comparison, could this be the case?
If I take the baseline DQM root files from
https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-baseline-tests/CMSSW_11_1_X_2020-02-03-1100/slc7_amd64_gcc820/-GenuineIntel/matrix-results/
I get manually the same results as the bin by bin tool, besides RelMon sees the same differences too: just some histograms which have changed their folder

[silviodonato]

unhold
ok, I will integrate this in the next IB

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1