Fix valgrind unit test for clang #28855

makortel · 2020-02-03T09:38:12Z

PR description:

The valgrind unit test is failing in CLANG IBs, presumably because clang appears to compile the test program to just ret (https://godbolt.org/z/nJY8Dg). Declaring the variable volatile seems to get clang to produce a non-trivial program.

PR validation:

Unit test runs on gcc build.

…k away

cmsbuild · 2020-02-03T09:38:34Z

The code-checks are being triggered in jenkins.

makortel · 2020-02-03T09:40:32Z

FYI @fabiocos @mrodozov (since we just talked about it)

cmsbuild · 2020-02-03T09:44:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28855/13606

This PR adds an extra 12KB to repository

cmsbuild · 2020-02-03T09:44:49Z

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Utilities/ReleaseScripts

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

makortel · 2020-02-03T09:49:20Z

@cmsbuild, please test for CMSSW_11_1_CLANG_X

cmsbuild · 2020-02-03T09:49:43Z

The tests are being triggered in jenkins.
Test Parameters:

RELEASE_FORMAT = CMSSW_11_1_CLANG_X
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4468/console Started: 2020/02/03 11:04

fabiocos · 2020-02-03T10:00:30Z

@smuzaffar @mrodozov for my information, how is this test command supposed to work? As far as I can see

10:57 cmsdev25 943> pwd
/build/fabiocos/111X/clang_issue/CMSSW_11_1_CLANG_X_2020-01-31-2300/src
10:58 cmsdev25 944> git branch -a | grep 11_1
  CMSSW_11_1_X
  from-CMSSW_11_1_CLANG_X_2020-01-31-2300
  remotes/official-cmssw/CMSSW_11_1_0_pre2
  remotes/official-cmssw/CMSSW_11_1_DEVEL_X
  remotes/official-cmssw/CMSSW_11_1_Patatrack_X
  remotes/official-cmssw/CMSSW_11_1_X

i.e. we do not have a CMSSW_11_1_CLANG_X branch, we do have a cmsdist CLANG branch. Or am I missing something?

smuzaffar · 2020-02-03T10:09:32Z

git-cms-merge-topic takes care of it

+ echo -e 'No release tags specified, using default CMSSW_11_1_CLANG_X_2020-02-02-2300.'
No release tags specified, using default CMSSW_11_1_CLANG_X_2020-02-02-2300.
+ CMSSW_TAG=CMSSW_11_1_CLANG_X_2020-02-02-2300
+ '[' '' ']'
++ echo CMSSW_11_1_CLANG_X_2020-02-02-2300
++ sed -e 's/\(CMSSW_[0-9][0-9]*_[0-9][0-9]*\).*/\1/'
+ CMSSW_BASE_BRANCH=CMSSW_11_1
+ case $CMSSW_TAG in
+ CMSSW_BRANCH=CMSSW_11_1_X
+ case `git --version` in
++ git --version
+ LEADING_SLASH=/
+ '[' ssh '!=' ssh ']'
+ '[' ssh = ssh ']'
+ [email protected]:cms-sw/cmssw.git
+ [email protected]:/cmssw.git
+ '[' /cvmfs/cms.cern.ch/cmssw.git.daily = '' ']'
+ '[' '!' -e /cvmfs/cms.cern.ch/cmssw.git.daily ']'
++ whoami
+ '[' -e /cvmfs/cms.cern.ch/cmssw.git.daily/create-cmsbld ']'
+ mkdir -p /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_CLANG_X_2020-02-02-2300/src
+ cd /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_CLANG_X_2020-02-02-2300/src
+ '[' '!' -d /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_CLANG_X_2020-02-02-2300/src/.git ']'
+ '[' /cvmfs/cms.cern.ch/cmssw.git.daily ']'
+ git clone --branch CMSSW_11_1_X --no-checkout --reference /cvmfs/cms.cern.ch/cmssw.git.daily --origin official-cmssw [email protected]:cms-sw/cmssw.git /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_CLANG_X_2020-02-02-2300/src
Cloning into '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_CLANG_X_2020-02-02-2300/src'...
+ false
+ git remote set-url --push official-cmssw disabled
+ git fetch official-cmssw --tags
+ git config core.sparsecheckout true
+ echo /.gitignore
+ echo /.clang-tidy
+ echo /.clang-format
+ git read-tree -mu HEAD
+ git checkout CMSSW_11_1_CLANG_X_2020-02-02-2300 -b from-CMSSW_11_1_CLANG_X_2020-02-02-2300
Switched to a new branch 'from-CMSSW_11_1_CLANG_X_2020-02-02-2300'

cmsbuild · 2020-02-03T11:12:42Z

+1
Tested at: 29b730f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b043c5/4468/summary.html
CMSSW: CMSSW_11_1_CLANG_X_2020-02-02-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-02-03T11:12:46Z

Comparison job queued.

cmsbuild · 2020-02-03T13:18:43Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b043c5/4468/summary.html

Comparison Summary:

You potentially added 5066 lines to the logs
Reco comparison results: 13330 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2697068
DQMHistoTests: Total failures: 24283
DQMHistoTests: Total nulls: 5
DQMHistoTests: Total successes: 2672434
DQMHistoTests: Total skipped: 346
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.023 KiB( 33 files compared)
DQMHistoSizes: changed ( 136.793 ): -0.023 KiB JetMET/SUSYDQM
Checked 147 log files, 16 edm output root files, 34 DQM output files

makortel · 2020-02-03T13:31:12Z

@cmsbuild, please test

Let's test the main IB as well

cmsbuild · 2020-02-03T13:31:36Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4473/console Started: 2020/02/03 14:40

cmsbuild · 2020-02-03T14:48:58Z

+1
Tested at: 29b730f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b043c5/4473/summary.html
CMSSW: CMSSW_11_1_X_2020-02-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-02-03T14:49:01Z

Comparison job queued.

cmsbuild · 2020-02-03T16:19:13Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b043c5/4473/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2697068
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2696721
DQMHistoTests: Total skipped: 346
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

makortel · 2020-02-03T16:45:07Z

+1

cmsbuild · 2020-02-03T16:45:28Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-02-03T17:31:14Z

+1

Declare variable volatile to prevent clang to optimize the memory lea…

29b730f

…k away

cmsbuild added this to the CMSSW_11_1_X milestone Feb 3, 2020

cmsbuild added code-checks-pending comparison-pending core-pending orp-pending pending-signatures tests-pending labels Feb 3, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 3, 2020

cmsbuild added tests-started and removed tests-pending labels Feb 3, 2020

cmsbuild added tests-approved and removed tests-started labels Feb 3, 2020

cmsbuild added comparison-available and removed comparison-pending labels Feb 3, 2020

cmsbuild removed comparison-available tests-approved labels Feb 3, 2020

cmsbuild added comparison-pending tests-pending labels Feb 3, 2020

cmsbuild added tests-started and removed tests-pending labels Feb 3, 2020

cmsbuild added tests-approved and removed tests-started labels Feb 3, 2020

cmsbuild added comparison-available and removed comparison-pending labels Feb 3, 2020

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Feb 3, 2020

cmsbuild added orp-approved and removed orp-pending labels Feb 3, 2020

cmsbuild merged commit 09b7a64 into cms-sw:master Feb 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix valgrind unit test for clang #28855

Fix valgrind unit test for clang #28855

makortel commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

makortel commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

makortel commented Feb 3, 2020

cmsbuild commented Feb 3, 2020 •

edited

Loading

fabiocos commented Feb 3, 2020

smuzaffar commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

makortel commented Feb 3, 2020

cmsbuild commented Feb 3, 2020 •

edited

Loading

cmsbuild commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

makortel commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

silviodonato commented Feb 3, 2020

Fix valgrind unit test for clang #28855

Fix valgrind unit test for clang #28855

Conversation

makortel commented Feb 3, 2020

PR description:

PR validation:

cmsbuild commented Feb 3, 2020

makortel commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

makortel commented Feb 3, 2020

cmsbuild commented Feb 3, 2020 • edited Loading

fabiocos commented Feb 3, 2020

smuzaffar commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

makortel commented Feb 3, 2020

cmsbuild commented Feb 3, 2020 • edited Loading

cmsbuild commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

makortel commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

silviodonato commented Feb 3, 2020

cmsbuild commented Feb 3, 2020 •

edited

Loading

cmsbuild commented Feb 3, 2020 •

edited

Loading