-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD geometry: add test workflows for scenario D53, update material budget validation #28834
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28834/13568
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: Configuration/PyReleaseValidation @kmaeshima, @andrius-k, @Dr15Jones, @chayanit, @cvuosalo, @civanch, @schneiml, @ianna, @mdhildreth, @cmsbuild, @makortel, @jfernan2, @fioriNTU, @zhenhu, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@pmeridian @parbol FYI |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@jfernan2 indeed this PR is not supposed to affect DQM output of any standard workflow, the validation of material budget is made with standalone configurations |
+upgrade |
+1 |
@chayanit comments? Objections? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a follow-up of #28788 adding:
definition of test workflows for scenario D53 in the upgrade section of PyReleaseValidation. No test is added to the standard matrix, as the workflows is fully functional up to GEN-SIM, the RECO geometry needs to be updated. Anyway the availability of the definition is useful to perform tests and debugging;
update of Validation/Geometry adding the materials needed by the new ETL. This allows the user to produce material budget plots for the new scenario D53, showing the increase in the ETL region due to the double disk structure.
PR validation:
The produced material budget plot is linked above. Test workflows runs in step1, and fail as expected for the time being in step2.