-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DD4hep] DDFilteredView current volume path and its copy numbers #28809
[DD4hep] DDFilteredView current volume path and its copy numbers #28809
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28809/13512
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: DetectorDescription/DDCMS @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@ianna @cvuosalo @silviodonato Can this PR be merged soon because calorimetric codes depend on this PR |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
path
that returns a path to a current node. Please, use it sparingly.copyNos
that returns a vector of the volumes copy numbers along the path. The vector index indicates the volume level, e.g. an index 0 refers to the current volume copy number, an index 1 refers to the current volume's parent copy number and so on.as requested by @bsunanda
Note: none of the above is needed if the xml selection parts specified in more details.
PR validation:
See
DetectorDescription/DDCMS/test/DDFilteredView.cppunit.cc
if this PR is a backport please specify the original PR:
Before submitting your pull requests, make sure you followed this checklist: