Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx230 Attempt to move reco geometry to DD4Hep #28774

Merged
merged 5 commits into from
Jan 27, 2020

Conversation

bsunanda
Copy link
Contributor

PR description:

First set of corrections to make reco geometry of HGCal from dd4hep interface

PR validation:

Use standard runTheMatrix.py for the used workflows

if this PR is a backport please specify the original PR:

Nothing special

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28774/13429

  • This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28774/13431

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 21, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4304/console Started: 2020/01/21 23:10

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: a087266
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0031f1/4304/summary.html
CMSSW: CMSSW_11_1_X_2020-01-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28774/13455

  • This PR adds an extra 32KB to repository

  • Found files with invalid states:

    • Traceback (most recent call last):
      • File "/build/cmsbld/jenkins/workspace/run-pr-code-checks/cms-bot/process-pull-request", line 35, in
        • pr = repo.get_pull(prId)
      • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/shared/github/Repository.py", line 1839, in get_pull
        • self.url + "/pulls/" + str(number)
      • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/shared/github/Requester.py", line 172, in requestJsonAndCheck
        • return self.__check(*self.requestJson(verb, url, parameters, headers, input, cnx))
      • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/shared/github/Requester.py", line 180, in __check
        • raise self.__createException(status, responseHeaders, output)
    • github.GithubException.GithubException: 504 {'data': '\r\n<title>504 Gateway Time-out</title>\r\n\r\n

      504 Gateway Time-out

      \r\n
      nginx\r\n\r\n\r\n'}

@cmsbuild
Copy link
Contributor

Pull request #28774 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 23, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4333/console Started: 2020/01/23 17:13

@cmsbuild
Copy link
Contributor

+1
Tested at: c9241bb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0031f1/4333/summary.html
CMSSW: CMSSW_11_1_X_2020-01-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0031f1/4333/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697090
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696743
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cvuosalo
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fadc536 into cms-sw:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants