Reduce dependencies on RecoEgamma and requirements for RecoEgamma #28684

guitargeek · 2019-12-27T13:36:07Z

PR description:

To make cmssw a bit more modular, I looked at the RecoEgamma packages and tried to remove all unused requirements. At the same time, I looked at the spots where other parts of cmssw depend on RecoEgamma and tried to remove these dependencies where possible. The ElectronIdentification and PhotonIdentification packages got special attention, and all sources in these libraries which are only used for plugins were moved into the plugins directory to make this more explicit.

PR validation:

CMSSW compiles and local matrix tests pass.

if this PR is a backport please specify the original PR:

No backport intended.

cmsbuild · 2019-12-27T13:36:35Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-12-27T13:45:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28684/13255

This PR adds an extra 208KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMOffline/Trigger/plugins/LepHTMonitor.cc modified in PR(s): DQM: Remove dqmEndRun in DQMEDAnalyzer #28552, [DQMOffline/Trigger] added "requireValidHLTPaths" flag to plugins using GenericTriggerEventFlag #28627, DQM: new DQMStore. #28622
- File Validation/RecoEgamma/plugins/PhotonValidator.h modified in PR(s): DQM: Remove dqmEndRun in DQMEDAnalyzer #28552, DQM: new DQMStore. #28622

cmsbuild · 2019-12-27T13:45:55Z

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CommonTools/RecoUtils
Configuration/Skimming
DQM/Physics
DQM/TrackingMonitorSource
DQMOffline/EGamma
DQMOffline/Ecal
DQMOffline/Trigger
ElectroWeakAnalysis/WENu
HLTrigger/Egamma
L1Trigger/L1TNtuples
RecoBTag/SoftLepton
RecoEcal/EgammaClusterAlgos
RecoEcal/EgammaClusterProducers
RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaIsolationAlgos
RecoEgamma/EgammaPhotonAlgos
RecoEgamma/EgammaPhotonProducers
RecoEgamma/ElectronIdentification
RecoEgamma/Examples
RecoEgamma/PhotonIdentification
RecoParticleFlow/PFProducer
RecoParticleFlow/PFTracking
TrackingTools/TrajectoryState
Validation/RecoEgamma

@perrotta, @kmaeshima, @benkrikler, @cmsbuild, @chayanit, @zhenhu, @fwyzard, @schneiml, @andrius-k, @pgunnell, @rekovic, @jfernan2, @fioriNTU, @Martin-Grunewald, @slava77, @santocch can you please review it and eventually sign? Thanks.
@rappoccio, @felicepantaleo, @jainshilpi, @hatakeyamak, @emilbols, @argiro, @HeinerTholen, @fioriNTU, @thomreis, @abbiendi, @varuns23, @seemasharmafnal, @mmarionncern, @smoortga, @hdelanno, @JyothsnaKomaragiri, @makortel, @threus, @acaudron, @jhgoh, @lgray, @missirol, @HuguesBrun, @cericeci, @ferencek, @trocino, @rociovilar, @Sam-Harper, @cbernet, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @jandrea, @idebruyn, @ebrondol, @mtosi, @dgulhan, @kreczko, @Martin-Grunewald, @battibass, @Fedespring, @calderona, @mverzett, @sobhatta, @folguera, @afiqaize, @gpetruc, @andrzejnovak, @pvmulder, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos, @silviodonato you are the release manager for this.

cms-bot commands are listed here

perrotta · 2019-12-27T14:47:25Z

please test

cmsbuild · 2019-12-27T14:47:52Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4105/console Started: 2019/12/27 15:48

cmsbuild · 2019-12-27T16:38:04Z

+1
Tested at: 1fdd8e2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef0eba/4105/summary.html
CMSSW: CMSSW_11_1_X_2019-12-26-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2019-12-27T16:38:08Z

Comparison job queued.

cmsbuild · 2019-12-27T18:05:34Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef0eba/4105/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2815765
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2815417
DQMHistoTests: Total skipped: 346
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

Martin-Grunewald · 2019-12-31T05:44:55Z

+1

cmsbuild · 2020-01-10T17:38:36Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef0eba/4193/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2696324
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2695977
DQMHistoTests: Total skipped: 346
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

jfernan2 · 2020-01-10T17:44:41Z

+1
No dqm changes

perrotta · 2020-01-11T07:20:51Z

+1

Only rebased since last reco signature in Reduce dependencies on RecoEgamma and requirements for RecoEgamma #28684 (comment)

tocheng · 2020-01-11T07:22:43Z

+1

chayanit · 2020-01-12T06:22:17Z

+1

santocch · 2020-01-12T20:53:33Z

+1

perrotta · 2020-01-13T14:27:25Z

Just to avoid having to rebase once more:

@benkrikler,@rekovic could you please have a look and sign, if you think so, for L1?
@Martin-Grunewald you already signed for HLT before the rebase, I think you can redo it now

Martin-Grunewald · 2020-01-13T14:50:25Z

+1

silviodonato · 2020-01-15T17:37:19Z

+1

silviodonato · 2020-01-15T17:37:43Z

merge
@rekovic this PR changes only one line of L1

cmsbuild added this to the CMSSW_11_1_X milestone Dec 27, 2019

cmsbuild added analysis-pending code-checks-pending comparison-pending dqm-pending hlt-pending l1-pending orp-pending pdmv-pending pending-signatures reconstruction-pending tests-pending labels Dec 27, 2019

cmsbuild removed the code-checks-pending label Dec 27, 2019

cmsbuild added the code-checks-approved label Dec 27, 2019

cmsbuild added tests-started and removed tests-pending labels Dec 27, 2019

cmsbuild added tests-approved and removed tests-started labels Dec 27, 2019

cmsbuild added comparison-available and removed comparison-pending labels Dec 27, 2019

cmsbuild mentioned this pull request Dec 30, 2019

Remove dead assignments in Validation/RecoEgamma/plugins #28687

Merged

cmsbuild added the tests-approved label Jan 10, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jan 10, 2020

cmsbuild added dqm-approved and removed dqm-pending labels Jan 10, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jan 11, 2020

cmsbuild added alca-approved and removed alca-pending labels Jan 11, 2020

cmsbuild added pdmv-approved and removed pdmv-pending labels Jan 12, 2020

cmsbuild added analysis-approved and removed analysis-pending labels Jan 12, 2020

cmsbuild added hlt-approved and removed hlt-pending labels Jan 13, 2020

cmsbuild added orp-approved and removed orp-pending labels Jan 15, 2020

cmsbuild merged commit fb6a956 into cms-sw:master Jan 15, 2020

guitargeek deleted the RecoEgamma_deps branch January 15, 2020 21:27

guitargeek mentioned this pull request Jan 16, 2020

No need for GsfElectronCoreBaseProducer and merging .h and .cc files for EgammaElectronProducers #28746

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce dependencies on RecoEgamma and requirements for RecoEgamma #28684

Reduce dependencies on RecoEgamma and requirements for RecoEgamma #28684

guitargeek commented Dec 27, 2019 •

edited

Loading

cmsbuild commented Dec 27, 2019

cmsbuild commented Dec 27, 2019

cmsbuild commented Dec 27, 2019

perrotta commented Dec 27, 2019

cmsbuild commented Dec 27, 2019 •

edited

Loading

cmsbuild commented Dec 27, 2019

cmsbuild commented Dec 27, 2019

cmsbuild commented Dec 27, 2019

Martin-Grunewald commented Dec 31, 2019

cmsbuild commented Jan 10, 2020

jfernan2 commented Jan 10, 2020

perrotta commented Jan 11, 2020

tocheng commented Jan 11, 2020

chayanit commented Jan 12, 2020

santocch commented Jan 12, 2020

perrotta commented Jan 13, 2020

Martin-Grunewald commented Jan 13, 2020

silviodonato commented Jan 15, 2020

silviodonato commented Jan 15, 2020

Reduce dependencies on RecoEgamma and requirements for RecoEgamma #28684

Reduce dependencies on RecoEgamma and requirements for RecoEgamma #28684

Conversation

guitargeek commented Dec 27, 2019 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Dec 27, 2019

cmsbuild commented Dec 27, 2019

cmsbuild commented Dec 27, 2019

perrotta commented Dec 27, 2019

cmsbuild commented Dec 27, 2019 • edited Loading

cmsbuild commented Dec 27, 2019

cmsbuild commented Dec 27, 2019

cmsbuild commented Dec 27, 2019

Martin-Grunewald commented Dec 31, 2019

cmsbuild commented Jan 10, 2020

jfernan2 commented Jan 10, 2020

perrotta commented Jan 11, 2020

tocheng commented Jan 11, 2020

chayanit commented Jan 12, 2020

santocch commented Jan 12, 2020

perrotta commented Jan 13, 2020

Martin-Grunewald commented Jan 13, 2020

silviodonato commented Jan 15, 2020

silviodonato commented Jan 15, 2020

guitargeek commented Dec 27, 2019 •

edited

Loading

cmsbuild commented Dec 27, 2019 •

edited

Loading