PPS: address comments

[jan-kaspar]

PR description:

This mostly-technical PR aims to address two suggestions by @fabiocos.

• PPS: update of Validation/CTPPS #28492 (comment): use random numbers from CLHEP and provide elementary reproducibility
• PPS proton reconstruction #25495 (review): move
  Validation/CTPPS/python/randomXiThetaGunProducer_cfi.py to Configuration/Generator

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28615/13136

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

CalibPPS/ESProducers
Configuration/Generator
Validation/CTPPS

@SiewYan, @andrius-k, @mkirsano, @kmaeshima, @christopheralanwest, @schneiml, @efeyazgan, @tocheng, @cmsbuild, @franzoni, @jfernan2, @agrohsje, @fioriNTU, @tlampen, @alberto-sanchez, @pohsun, @qliphy can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @forthommel, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3950/console Started: 2019/12/12 16:39

[cmsbuild]

+1
Tested at: 67e05de
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23149f/3950/summary.html
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23149f/3950/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2798405
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2798063
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[jfernan2]

+1

[fabiocos]

@jan-kaspar thank you, did you verify this update with the validation configuration?

[jan-kaspar]

@fabiocos Yes. A test based on this config (including the files from Validation/CTPPS/python/simu_config), made for the 2018 configuration, yields the following simulated x distributions in the 4 Roman Pots (columns):

Blue: before this PR, red-dashed: with this PR. No change observed, as expected.

[fabiocos]

@christopheralanwest @tocheng @tlampen the update is mostly technical, could you please have a look?
@qliphy @agrohsje the update in your area is marginal

[pohsun]

+1

[fabiocos]

+1

[fabiocos]

merge