Removing the RPCEfficiency folder and unused plots in the RPC DQM

[jeongsumin]

PR description:

This PR is contained about remove the "RPCEfficiency" folder which seems to be never used in RPC DQM.

In the offline DQM, there are several memory problems (this is running in Tier0).
And DQM offline may have more histograms (~17k).

So, we need to reorganize what is unused or used.

In the first step, we should remove this folder which is contained 4667 histograms and other unused plots.

• If there is objection about remove unused normalization plots, I will recover that part.

PR validation:

I tested these changes with runTheMatrix.py 136.867 (RunSingleMu2018B) & 30.0 (ZMM)

if this PR is a backport please specify the original PR:

N/A

@jhgoh @andresib I made a new PR from the CMSSW_11_0_X branch.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28431/12830

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/RPCMonitorClient/python/RPCTier0Client_cff.py modified in PR(s): DQM: Remove ClientConfig package #28380, DQM: Configuration alias for QualityTester #28375, DQM: Restructure QTests (v2) #28379, DQM: new DQMGlobalEDAnalyzer #28407

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28431/12830/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28431/12830/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28431/12834

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/RPCMonitorClient/python/RPCTier0Client_cff.py modified in PR(s): DQM: Remove ClientConfig package #28380, DQM: Configuration alias for QualityTester #28375, DQM: Restructure QTests (v2) #28379, DQM: new DQMGlobalEDAnalyzer #28407

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28431/12834/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28431/12834/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28431/12835

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/RPCMonitorClient/python/RPCTier0Client_cff.py modified in PR(s): DQM: Remove ClientConfig package #28380, DQM: Configuration alias for QualityTester #28375, DQM: Restructure QTests (v2) #28379, DQM: new DQMGlobalEDAnalyzer #28407

[cmsbuild]

A new Pull Request was created by @jeongsumin (jeongsumin) for master.

It involves the following packages:

DQM/RPCMonitorClient
DQM/RPCMonitorDigi

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@acimmino this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3562/console Started: 2019/11/20 18:51

[cmsbuild]

+1
Tested at: 0c8739d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-96d3c6/3562/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-96d3c6/3562/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2785613
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785271
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -43972.61 KiB( 33 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): -1381.521 KiB RPC/RPCEfficiency
• DQMHistoSizes: changed ( 1000.0,... ): -22.777 KiB RPC/AllHits
• DQMHistoSizes: changed ( 1000.0,... ): -22.695 KiB RPC/Muon
• DQMHistoSizes: changed ( 10024.0,... ): -1575.584 KiB RPC/RPCEfficiency
• DQMHistoSizes: changed ( 140.53 ): -1339.006 KiB RPC/RPCEfficiency
• DQMHistoSizes: changed ( 20034.0 ): -2190.709 KiB RPC/RPCEfficiency
• DQMHistoSizes: changed ( 20434.0,... ): -1920.709 KiB RPC/RPCEfficiency
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1