-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
106X backport of isolated particle level photon #28411
106X backport of isolated particle level photon #28411
Conversation
A new Pull Request was created by @AndrewLevin for CMSSW_10_6_X. It involves the following packages: GeneratorInterface/RivetInterface @SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @fgolf, @alberto-sanchez, @agrohsje, @qliphy, @santocch, @peruzzim can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
Can this be merged? |
+xpog same comment as #28409 (comment) |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Replaces the current photon collection in the Rivet particle level producer with a collection of isolated photons. The photon pt cut, photon eta cut, isolation cone size, and isolation cut are configurable.
PR validation:
I have run this producer on a recent TTBar and HGG relval sample, and found that the producer produces the expected number of isolated photons in each case.
if this PR is a backport please specify the original PR:
#28371