Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color reconnection tunes for CP5 #28347

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

efeyazgan
Copy link
Contributor

backport of #28340

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2019

A new Pull Request was created by @efeyazgan (Efe Yazgan) for CMSSW_10_6_X.

It involves the following packages:

Configuration/Generator

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@efeyazgan
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3350/console Started: 2019/11/05 14:55

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61455b/3350/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211989
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Nov 6, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Nov 6, 2019

+1

@cmsbuild cmsbuild merged commit ce981e0 into cms-sw:CMSSW_10_6_X Nov 6, 2019
@qliphy
Copy link
Contributor

qliphy commented Nov 6, 2019

@fabiocos Thanks a lot!. As TOP PAG needs this (together with #28352) for relevant requests. Can we have updated 10_6_X and 9_3_X release the sooner the better? Thanks a lot in advance!

@efeyazgan efeyazgan deleted the cr1cr2forcp5 branch November 6, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants