Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation #2833

Merged
merged 5 commits into from
Mar 17, 2014
Merged

Validation #2833

merged 5 commits into from
Mar 17, 2014

Conversation

kasmi
Copy link

@kasmi kasmi commented Mar 12, 2014

Some fixes to the Validation package for HcalRecHits and HcalDigis plots.

@kasmi kasmi closed this Mar 12, 2014
@kasmi kasmi reopened this Mar 12, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kasmi (Azeddine Kasmi) for CMSSW_6_2_X_SLHC.

Validation

It involves the following packages:

Validation/CaloTowers
Validation/HcalDigis
Validation/HcalRecHits

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@kasmi
Copy link
Author

kasmi commented Mar 13, 2014

+1

From: cmsbuild [[email protected]]
Sent: Wednesday, March 12, 2014 5:48 PM
To: cms-sw/cmssw
Cc: Azeddine Kasmi
Subject: Re: [cmssw] Validation (#2833)

A new Pull Request was created by @kasmihttps://github.com/kasmi (Azeddine Kasmi) for CMSSW_6_2_X_SLHC.

Validation

It involves the following packages:

Validation/CaloTowers
Validation/HcalDigis
Validation/HcalRecHits

@ojedahttps://github.com/ojeda, @dandugganhttps://github.com/danduggan, @roverehttps://github.com/rovere, @cmsbuildhttps://github.com/cmsbuild, @nclopezohttps://github.com/nclopezo, @deguiohttps://github.com/deguio, @deganohttps://github.com/degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacobhttps://github.com/andersonjacob, @mark-grimeshttps://github.com/mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2833#issuecomment-37478895.

@andersonjacob
Copy link
Contributor

There is a segmentation violation in HcalRecHitsClient:hcalrechitsClient@endRun for

runTheMatrix -w upgrade -l 10000,10200,11600,13000

This is the relevent portions of the call stack

#5  0x00002b0c61f81766 in MonitorElement::accessRootObject(char const*, int) const () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/
slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-03-17-0200/lib/slc5_amd64_gcc472/libDQMServicesCore.so
#6  0x00002b0c61f81e53 in MonitorElement::getBinContent(int, int) const () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_
gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-03-17-0200/lib/slc5_amd64_gcc472/libDQMServicesCore.so
#7  0x00002b0c71b9339e in HcalRecHitsClient::HcalRecHitsEndjob(std::vector<MonitorElement*, std::allocator<MonitorElement*> > const&) 
() from /afs/cern.ch/work/a/andersj/upgrade/CMSSW_6_2_X_SLHC_2014-03-17-0200/lib/slc5_amd64_gcc472/pluginValidationHcalRecHits.so
#8  0x00002b0c71b95b29 in HcalRecHitsClient::runClient_() () from /afs/cern.ch/work/a/andersj/upgrade/CMSSW_6_2_X_SLHC_2014-03-17-0200
/lib/slc5_amd64_gcc472/pluginValidationHcalRecHits.so
#9  0x00002b0c530e7330 in edm::EDAnalyzer::doEndRun(edm::RunPrincipal const&, edm::EventSetup const&, edm::CurrentProcessingContext co
nst*) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-03-17-0200/lib/slc5_amd64_g
cc472/libFWCoreFramework.so

Event before this there are some errors of this sort which might need to be sorted out

 Number of histos 189
%MSG-e HcalDigisClient:  HcalDigisClient:hcaldigisClient@endRun  17-Mar-2014 15:59:26 CET End Run: 1
No nevtot or maps histo found...
%MSG
%MSG-e HcalDigisClient:  HcalDigisClient:hcaldigisClient@endRun  17-Mar-2014 15:59:26 CET End Run: 1
Error in HcalDigisEndjob! HB
%MSG
 Number of histos 189
%MSG-e HcalDigisClient:  HcalDigisClient:hcaldigisClient@endRun  17-Mar-2014 15:59:26 CET End Run: 1
No nevtot or maps histo found...
%MSG
%MSG-e HcalDigisClient:  HcalDigisClient:hcaldigisClient@endRun  17-Mar-2014 15:59:26 CET End Run: 1
Error in HcalDigisEndjob! HE
%MSG
 Number of histos 189
%MSG-e HcalDigisClient:  HcalDigisClient:hcaldigisClient@endRun  17-Mar-2014 15:59:26 CET End Run: 1
No nevtot or maps histo found...
%MSG
%MSG-e HcalDigisClient:  HcalDigisClient:hcaldigisClient@endRun  17-Mar-2014 15:59:26 CET End Run: 1
Error in HcalDigisEndjob! HO
%MSG
 Number of histos 189
%MSG-e HcalDigisClient:  HcalDigisClient:hcaldigisClient@endRun  17-Mar-2014 15:59:26 CET End Run: 1
No nevtot or maps histo found...
%MSG
%MSG-e HcalDigisClient:  HcalDigisClient:hcaldigisClient@endRun  17-Mar-2014 15:59:26 CET End Run: 1
Error in HcalDigisEndjob! HF
%MSG
%MSG-e FatalSystemSignal:  HcalRecHitsClient:hcalrechitsClient@endRun  17-Mar-2014 15:59:26 CET End Run: 1
A fatal system signal has occurred: segmentation violation
%MSG

@cmsbuild
Copy link
Contributor

Pull request #2833 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@andersonjacob
Copy link
Contributor

merge

With the updates tests exhibit only known failures.

@cmsbuild
Copy link
Contributor

Pull request #2833 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

cmsbuild added a commit that referenced this pull request Mar 17, 2014
@cmsbuild
Merge pull request #2833 from kasmi/Validation
75ec925 
Validation
@cmsbuild cmsbuild merged commit 75ec925 into cms-sw:CMSSW_6_2_X_SLHC Mar 17, 2014
mark-grimes
mark-grimes reviewed Mar 19, 2014
View reviewed changes
Validation/HcalDigis/src/HcalDigisClient.cc
@@ -33,13 +33,13 @@
//dbe_->setCurrentFolder(dirName_);
dbe_->setCurrentFolder("HcalDigisV/HcalDigiTask");

// false for regular relval and true for SLHC relval
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has reintroduced a bug fixed by #2483. doSLHC_ must be set before the call to booking(...).
This has already been merged so I'll put in another pull request to fix it.

@mark-grimes mark-grimes mentioned this pull request Mar 19, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dqm-pending orp-pending pending-signatures tests-pending
Projects
None yet
Milestone
Next CMSSW_6_2_X_SLHC
Development

Successfully merging this pull request may close these issues.
4 participants
@kasmi @cmsbuild @andersonjacob @mark-grimes