-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SiPixAli PCL DQM output #28318
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28318/12560
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Alignment/MillePedeAlignmentAlgorithm @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28318/12561
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
As part of the effort done to avoid exotic error states with the SiPixelAli PCL workflow (see PRs #28306 and cms-sw/cmsdist#5309) we profited to introduce few new
MonitorElement
s to display the status of the alignment fit.The introduced plots are:
PR validation:
The SiPixelAli PCL workflow for run 317212 has been re-run with the changes proposes here, using the command:
which run to completion, producing the desired output plots.
Here is a screenshot of the output DQM file uploaded to a private development DQM GUI:
if this PR is a backport please specify the original PR:
This PR is not a backport.
cc:
@adewit @connorpa @dmeuser