Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong parenthesis in era switches for UL [106X] #28302

Merged
merged 1 commit into from
Oct 30, 2019

Conversation

peruzzim
Copy link
Contributor

PR description:

A bugfix (wrong parenthesis usage) to address the errors in RelVal workflows recently observed in the IB #28119 (comment)

PR validation:

Checked in the cms-nanoAOD integration repository for the main workflows, will re-test here for those that were crashing.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @peruzzim for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @fgolf, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@peruzzim
Copy link
Contributor Author

please test workflow 1325.6,1325.7,1325.8,1329.1,136.7722,136.7952,136.8521,11824.0,11825.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 29, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3220/console Started: 2019/10/29 14:04

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9a02b/3220/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-b9a02b/11824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021PU_GenSimFull+DigiFullPU_2021PU+RecoFullPU_2021PU+HARVESTFullPU_2021PU+NanoFull_2021PU
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-b9a02b/11825.0_ZEE_13+ZEE_13TeV_TuneCUETP8M1_2021PU_GenSimFull+DigiFullPU_2021PU+RecoFullPU_2021PU+HARVESTFullPU_2021PU+NanoFull_2021PU

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211989
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@peruzzim
Copy link
Contributor Author

+xpog

configuration fixed

@fabiocos
Copy link
Contributor

+1

@peruzzim thanks

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 9d8cd7a into cms-sw:CMSSW_10_6_X Oct 30, 2019
@peruzzim peruzzim deleted the peruzzim-patch-1 branch October 30, 2019 15:06
@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will be automatically merged.

@peruzzim peruzzim mentioned this pull request Oct 31, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants