Fix GCC9 warning in NavigationSchoolAnalyzer #28296
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28296/12484
|
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: RecoTracker/TkNavigation @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
| @@ -84,6 +84,7 @@ void NavigationSchoolAnalyzer::print(std::ostream& os, const DetLayer* dl) { | |||
| break; | |||
| case GeomDetEnumerators::RPCEndcap: | |||
| side = (unsigned int)((RPCDetId(tag->geographicalId().rawId()).region() / 2. + 1) * 2.); | |||
| [[fallthrough]]; | |||
| case GeomDetEnumerators::RPCBarrel: | |||
| LorW = RPCDetId(tag->geographicalId().rawId()).station(); | |||
There was a problem hiding this comment.
I believe the intention is to fall through (for RPC endcap both side and LorW are needed, and LorW is obtained with the same code for both endcap and barrel).
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR fixes a GCC 9 warning by adding the
[[fallthrough]]attribute to denote an intentional fallthrough.PR validation:
Code compiles with GCC 9 without warnings.