Add missing header for TLeaf to avoid incomplete type complain

[mrodozov]

PR description:

Add a header for TLeaf to shut this:
error: invalid use of incomplete type 'class TLeaf'
result of
TBranch* br = leaf->GetBranch();
on line 162

PR validation:

It compiles. It was failing to compile. Needed for cms-sw/cmsdist#5276

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5276
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2918/console Started: 2019/10/14 17:20

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28166/12236

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

IOPool/Input

@smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2923/console Started: 2019/10/14 18:19

[cmsbuild]

+1
Tested at: 6fc4e48
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38ffd2/2923/summary.html

[cmsbuild]

Comparison job queued.

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38ffd2/2923/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2961064
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960722
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[fabiocos]

+1

[cmsbuild]

-1

Tested at: 6fc4e48

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70109f/2918/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test FKDTree_t had ERRORS
---> test testTables had ERRORS
---> test materialBudgetTrackerPlots had ERRORS
---> test testImports had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70109f/2918/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2961064
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960722
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[fabiocos]

@smuzaffar @mrodozov apparently the issues with the unit tests are not reproducible in today's IB, and seemed transient problems

[smuzaffar]

issue only appears when we move to new ROOT6 which we have not yet ( cms-sw/cmsdist#5276 is still open).

[smuzaffar]

failure you see here #28166 (comment) are due to new root master