Enable pt-dependent JER-SF and phi-dependent JEC application in PAT [102X backport]

[ahinzmann]

PR description:

Enable pt-dependent jet resolution scale factors in PAT. This is needed to apply Autumn18_V7 JER-SF, released last week.
Enable phi-dependent jet energy scale in PAT. This will be needed for 2018 JEC to deal with the HEM issue.
This PR has no impact with the current global tags in any release. However, it will enable using a new global tag (currently in the makings) with pt-dependent JER-SFs and later with phi-dependent JECs.

A test config to apply resolution smearing from a db file has been added under /test.
Here is an example db-file containing pt-dependent JER-SFs:
https://github.com/cms-jet/JRDatabase/blob/master/SQLiteFiles/Autumn18_V7_MC.db

PR validation:

Test config runs after inclusion of this PR. It was checked that this does not change the memory consumption, compared to using the old code with Autumn18_V1_MC.db (no pt-dependence).

if this PR is a backport please specify the original PR:

Backport of #28096

[cmsbuild]

A new Pull Request was created by @ahinzmann for CMSSW_10_2_X.

It involves the following packages:

JetMETCorrections/Modules
PhysicsTools/PatAlgos
PhysicsTools/PatUtils

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@emilbols, @gouskos, @rappoccio, @HeinerTholen, @peruzzim, @seemasharmafnal, @mmarionncern, @smoortga, @acaudron, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Enable pt-dependent JER-SF and phi-dependent JEC application in PAT #28096

[ahinzmann]

@peruzzim runMETCorrectionsAndUncertainties is affected by this and I assume you re-run it for the new NanoAOD with the new JER/JEC. Thus this PR is necessary for the NanoAODv6 production.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2771/console Started: 2019/10/03 11:55

[slava77]

@ahinzmann
are the additional numerous differences in the modified files from just the clang formatting in addition to the changes in the #28077 or does this also include a backport of other developments?

[ahinzmann]

Hi Slava, this is all clang formatting, no additional developments. Best, Andreas

…

Am 03.10.2019 um 11:55 schrieb Slava Krutelyov ***@***.***>: @ahinzmann are the additional numerous differences in the modified files from just the clang formatting in addition to the changes in the #28077 or does this also include a backport of other developments? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[cmsbuild]

+1
Tested at: f86a0b8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19806d/2771/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19806d/2771/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007468
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3007277
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[cmsbuild]

Pull request #28098 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2806/console Started: 2019/10/06 16:17

[cmsbuild]

+1
Tested at: 15fb757
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19806d/2806/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19806d/2806/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007468
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3007276
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[slava77]

backport of #28096
this is more of a copy-paste from the master version though; it includes clang-format changes on top of #28096

[slava77]

+1

for #28098 15fb757

• code changes are in line with the PR description; added to support additional parameterization in the JEC/JER
• the backport is essentially correct (Enable pt-dependent JER-SF and phi-dependent JEC application in PAT [106X backport] #28097 (review))
• jenkins tests pass and comparisons with the baseline show no differences

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1