-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve upgrade PU assignment #28005
Conversation
The code-checks are being triggered in jenkins. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28005/11909
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages: Configuration/PyReleaseValidation @chayanit, @pgunnell, @cmsbuild, @kpedro88, @zhenhu can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
In #25996, Phase 2 PU workflows were configured to use 200PU automatically. However, this configuration relied on the name of the default dataset, which a) isn't always set and b) no longer necessarily matches the workflow year because of the recent 2023 -> 2026 change in #27488. Instead, the year can be matched to the key directly.
PR validation:
Tested runTheMatrix.py to make sure the right PU configuration was assigned to each year.