Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting the partitioning of 8-etaPartition GEM chamber #28

Closed
wants to merge 2 commits into from
Closed

Correcting the partitioning of 8-etaPartition GEM chamber #28

wants to merge 2 commits into from

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Jul 3, 2013

Hi,

This is to correct the 8 partition GEM geometry in CMSSW. Marcello Maggi made the changes a couple of weeks ago, but the changes were never queued or published in CVS. Could you add this fix please?

Thanks,
Sven

@dildick dildick closed this Jul 3, 2013
@dildick dildick reopened this Jul 5, 2013
@ktf
Copy link
Contributor

ktf commented Jul 5, 2013

How can we test this?

@ianna
Copy link
Contributor

ianna commented Jul 5, 2013

cmsRun Geometry/GEMGeometry/test/testGEMGeometry_cfg.py

@dildick
Copy link
Contributor Author

dildick commented Jul 5, 2013

I'm not sure whether Geometry/GEMGeometry/test/testGEMGeometry_cfg.py has all the functionality to test this. I could send you some plots we made a couple of weeks ago.

@ianna
Copy link
Contributor

ianna commented Jul 5, 2013

It would be nice if GEMGeometryAnalyzer could fully test GEM geometry on validity. Do you know what is missing there?

@ktf
Copy link
Contributor

ktf commented Jul 5, 2013

No need to send plots (but you are free to attach them to the ticket, if deemed useful), we just need to know some basic test to make sure everything is in the release as expected. @nclopezo can you try this out, please?

@ktf
Copy link
Contributor

ktf commented Jul 5, 2013

@ianna +1

@dildick
Copy link
Contributor Author

dildick commented Jul 5, 2013

@ianna: The GEMGeometryAnalyzer is missing a full implementation actually (I'll add it to my todo list)
https://github.com/cms-sw/cmssw/blob/CMSSW_6_2_X/Geometry/GEMGeometry/test/GEMGeometryAnalyzer.cc

I just noticed that the change in eta partition sizes was not included when I reopened the request (strange). The correction is displayed here:
https://github.com/gem-sw/cmssw/pull/5/files

The effect of the correction is visible here
https://indico.cern.ch/getFile.py/access?contribId=2&resId=1&materialId=slides&confId=253634

@ktf
Copy link
Contributor

ktf commented Jul 5, 2013

Can you also make the request to CMSSW_7_0_X, not CMSSW_6_2_X?

@ktf
Copy link
Contributor

ktf commented Jul 8, 2013

For the record: as discussed, changes in CMSSW_6_2_X must be done in CVS until CMSSW_6_2_0. Closing this down.

@ktf ktf closed this Jul 8, 2013
yetkinyilmaz referenced this pull request in CmsHI/cmssw Dec 23, 2013
@vciulli
Merge pull request #28 from dnash86/master
1fcc1a6 
Fixed Tune to pp 5
nclopezo pushed a commit to nclopezo/cmssw that referenced this pull request May 5, 2014
@ktf
Merge pull request cms-sw#28 from nclopezo/patch-4
8616bbd 
Changed milestone for 7_1_X to CMSSW_7_1_0_pre4
franzoni pushed a commit to franzoni/cmssw that referenced this pull request May 8, 2014
Merge pull request cms-sw#28 from samircury/harvest-optional-proxy
26a71bc 
Harvest optional proxy
@vandreev11 vandreev11 mentioned this pull request Jul 10, 2014
Merged
geonmo pushed a commit to geonmo/cmssw that referenced this pull request Jun 4, 2015
Merge pull request cms-sw#28 from mark-grimes/for-75X-GEM-CSC-Trigger…
7307d73 
…_smartPointers

Change pointer array to an array of unique_ptrs
yetkinyilmaz pushed a commit to yetkinyilmaz/cmssw that referenced this pull request Dec 7, 2015
@istaslis
Merge pull request cms-sw#28 from istaslis/forest_MIX_MC_bTag
7680a5d 
Updated PbPb MIX MC b-tag configs
@bouril bouril mentioned this pull request Mar 9, 2016
Closed
mmarionncern pushed a commit to mmarionncern/cmssw that referenced this pull request May 23, 2016
@gpetruc
Merge pull request cms-sw#28 from peruzzim/devel_80X
f325837 
Some initial adaptations for 80X
@bouril bouril mentioned this pull request Jun 15, 2016
Closed
jozzez1 pushed a commit to jozzez1/cmssw that referenced this pull request Jun 22, 2016
@quertenmont
Merge pull request cms-sw#28 from jozzez1/Run2HSCP_8XY_v0_Joze
0d6bda2 
HSCPHLTFilter.cc fix and some crab automation
@dan131riley dan131riley mentioned this pull request Jul 23, 2016
Closed
@ishvetso ishvetso mentioned this pull request Aug 29, 2016
Closed
mariadalfonso pushed a commit to mariadalfonso/cmssw that referenced this pull request May 6, 2017
@amarini
Merge pull request cms-sw#28 from amarini/topic_fixes
5f84cce 
Small bugs
tomcornelis pushed a commit to tomcornelis/cmssw that referenced this pull request Feb 15, 2018
@gpetruc
Merge pull request cms-sw#28 from HuguesBrun/puppyIn76X
34ad0da 
Puppi & relat tk iso
ajgilbert pushed a commit to ajgilbert/cmssw that referenced this pull request Jan 17, 2019
@Sam-Harper
Merge pull request cms-sw#28 from Sam-Harper/EgammaPostRecoTools_940
00e1ce4 
Fixing bug where pat objects not updated when only running VID
felicepantaleo referenced this pull request in felicepantaleo/cmssw Mar 28, 2019
@clelange
Merge pull request #28 from clelange/FixRetrieveLayerPositions
8365b3b 
change layer z position retrieval according to Sunanda - this will wo…
@bsunanda bsunanda mentioned this pull request Apr 25, 2019
Merged
gpetruc added a commit to gpetruc/cmssw that referenced this pull request Dec 11, 2019
@gpetruc
Merge pull request cms-sw#28 from p2l1pfp/therwig-patch-1
962fc36 
Adjust HF threshold from 17 to 15 GeV
aehart pushed a commit to aehart/cmssw that referenced this pull request Sep 18, 2020
@skinnari
Merge pull request cms-sw#28 from cms-L1TK/revert-26-tp_debug
245c490 
Revert "Fixed TP compilation errors."
franzoni pushed a commit to franzoni/cmssw that referenced this pull request May 3, 2021
@clelange
Merge pull request cms-sw#28 from predragm/AddOptions_MultiplePDGIDs_…
d90e519 
…ReClustering

fixing the build of the file "basename"...
henriettepetersen added a commit to henriettepetersen/cmssw that referenced this pull request Feb 21, 2022
@henriettepetersen
remove changes in DMR.py to avoid merge conflict with PR cms-sw#28 fr…
20c735e 
…om Tomas
dsrankin pushed a commit to dsrankin/cmssw that referenced this pull request Mar 9, 2022
@nhanvtran
Merge pull request cms-sw#28 from jngadiub/92X
5531168 
92 x
pjwinnetou added a commit to pjwinnetou/cmssw that referenced this pull request Jul 12, 2022
@pjwinnetou
Merge pull request cms-sw#28 from pjwinnetou/OniaTree_12_3_X
6cd98c7 
small fix in unpacker for L1 propagator
bendavid pushed a commit to bendavid/cmssw that referenced this pull request Feb 1, 2023
@kdlong
Merge pull request cms-sw#28 from erc-asymow/WmassNanoProd_10_6_26
23a960b 
Fix for NANOTP production
fwyzard referenced this pull request in fwyzard/cmssw Jun 29, 2023
@fwyzard
Merge pull request #28 from fwyzard/add_dictionary_for_SiPixelErrorCo…
8252595 
…mpact

Add a dictionary for `SiPixelErrorCompact`
@TomasKello TomasKello mentioned this pull request Feb 27, 2024
Closed
AuroraPerego added a commit to AuroraPerego/cmssw that referenced this pull request Apr 17, 2024
@AuroraPerego
ticlv5: adapt the validation to run with both v4 and v5 (cms-sw#28)
cc1fbf2 
* add candidates plots to makePlots and fix for v4/v5

* code format

* ticlv5: fix error in validation
waredjeb pushed a commit to waredjeb/cmssw that referenced this pull request Apr 18, 2024
@AuroraPerego @felicepantaleo
ticlv5: adapt the validation to run with both v4 and v5 (cms-sw#28)
1bf5b38 
* add candidates plots to makePlots and fix for v4/v5

* code format

* ticlv5: fix error in validation
AuroraPerego added a commit to AuroraPerego/cmssw that referenced this pull request Apr 19, 2024
@AuroraPerego @felicepantaleo
ticlv5: adapt the validation to run with both v4 and v5 (cms-sw#28)
5a2cecb 
* add candidates plots to makePlots and fix for v4/v5

* code format

* ticlv5: fix error in validation
waredjeb pushed a commit to waredjeb/cmssw that referenced this pull request Apr 19, 2024
@AuroraPerego @felicepantaleo
ticlv5: adapt the validation to run with both v4 and v5 (cms-sw#28)
64532f8 
* add candidates plots to makePlots and fix for v4/v5

* code format

* ticlv5: fix error in validation
AuroraPerego added a commit to AuroraPerego/cmssw that referenced this pull request May 2, 2024
@AuroraPerego @felicepantaleo
ticlv5: adapt the validation to run with both v4 and v5 (cms-sw#28)
e4bd013 
* add candidates plots to makePlots and fix for v4/v5

* code format

* ticlv5: fix error in validation
waredjeb pushed a commit to waredjeb/cmssw that referenced this pull request May 31, 2024
@AuroraPerego @waredjeb
ticlv5: adapt the validation to run with both v4 and v5 (cms-sw#28)
1c7600e 
* add candidates plots to makePlots and fix for v4/v5

* code format

* ticlv5: fix error in validation
kmohrman pushed a commit to kmohrman/cmssw that referenced this pull request Jul 2, 2024
@slava77
Merge pull request cms-sw#28 from SegmentLinking/CMSSW_14_1_0_pre3_LS…
8c86d7f 
…T_X_TSFixesAndSplitTCCollections

Usage of split TrackCandidate collections for LST objects and fixes/improvements for TrajectorySeed collections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dildick @ktf @ianna