Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premix option c, with 2 tags, ECAL, 11_0_X #27974

Closed

Conversation

amassiro
Copy link
Contributor

First implementation of the ECAL run dependent MC
Similar to #27970, but that was in 10_6_X

To be tested it needs this PR: #27649

Physics details in the presentation at ECAL DPG here: https://indico.cern.ch/event/847097/

This PR will affect only the mixing step, when the premixed library is mixed with the hard scattering. The idea is that the pileup response, that has been simulated with a given transparency for ECAL crystals, will be scaled to match the transparency of the corresponding IOV.
A new object is introduced ( EcalLaserAPDPNRatiosMCRcd ), that has 1 single IOV, thus allowing this to be used as reference for scaling.
Goal: correct simulation of the photostatistics for pileup, when producing run dependent MC with several IOVs (main changes in run dependent MC for ECAL are transparency and noise).

This PR is needed for testing via relval, checking physics performance and possibly imploved data-MC comparison.

@cmsbuild cmsbuild changed the base branch from CMSSW_11_0_X to master September 11, 2019 12:29
@cmsbuild
Copy link
Contributor

@amassiro, CMSSW_11_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27974/11854

  • This PR adds an extra 64KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@christopheralanwest
Copy link
Contributor

@amassiro Please rebase this PR to master to resolve the conflicts and then apply the code-checks/code-format.

@christopheralanwest
Copy link
Contributor

@amassiro Could you please rebase this PR?

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27974/11921

  • This PR adds an extra 68KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27974/11923

  • This PR adds an extra 240KB to repository

@cmsbuild
Copy link
Contributor

Pull request #27974 was updated. @civanch, @christopheralanwest, @mdhildreth, @cmsbuild, @franzoni, @tocheng, @tlampen, @ggovi, @pohsun can you please check and sign again.

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 24, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2648/console Started: 2019/09/24 15:49

@cmsbuild
Copy link
Contributor

-1

Tested at: 260a61d

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e971e/2648/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
250202.181 step3

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step3_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@amassiro
Copy link
Contributor Author

-1

Tested at: 260a61d

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e971e/2648/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
250202.181 step3

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step3_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

The error is shown here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e971e/2648/runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step3_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

and it's due to the missing:
No "EcalLaserDbRecordMC" record found in the EventSetup.n
But this is expected, since it's not a record available in any GT.

But as shown here:
https://indico.cern.ch/event/847097/contributions/3558586/attachments/1905881/3148121/Sep-11_ECAL_Massironi.pdf
we need to add the following
https://github.com/amassiro/EcalSIM/blob/master/Generation/RunIISummer19UL17DIGIPremix.py#L163

process.EcalLaserCorrectionServiceMC = cms.ESProducer("EcalLaserCorrectionServiceMC")

In the python script.

How do I add it in "run the matrix" ?

@srimanob
Copy link
Contributor

srimanob commented Sep 25, 2019

@amassiro @fabiocos
Do I understand correctly that you may need a dedicated workflow to test this?
I don't know that we should add ESProducer to a normal workflow that regular used for general validation (*)?

To add, you may need to go to the step PREMIXUP18_PU25 in
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_premix.py#L43

which points to

https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_steps.py#L1721-L1729
and add command in the cmsDriver.

(*)
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/scripts/runTheMatrix.py#L91

@amassiro
Copy link
Contributor Author

amassiro commented Oct 2, 2019

Hi, I'm not sure I have understood.

Where can I define the new line

process.EcalLaserCorrectionServiceMC = cms.ESProducer("EcalLaserCorrectionServiceMC")

to be picked up automatically by "runTheMatrix"?

@srimanob
Copy link
Contributor

srimanob commented Oct 7, 2019

Hi @amassiro

Sorry for late reply, I somehow miss this. I mean you may consider to modify
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_steps.py#L1747
to

steps['DIGIPRMXUP17_PU25']=merge([digiPremixUp2017Defaults25ns,{'--customise_commands':'"process.EcalLaserCorrectionServiceMC = cms.ES
Producer("EcalLaserCorrectionServiceMC")"'}])

However, this will change behavior of all 17 premixing relvals. What I proposed is to have a dedicated step, i.e. DIGIPRMXUP17_PU25_RD and we have a dedicated workflow to test.

If we have a new step, then we can add from
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_premix.py#L36
to, i.e.
workflows[250202.172]=['',['TTbar_13UP17','DIGIPRMXUP17_PU25_RD','RECOPRMXUP17_PU25','HARVESTUP17_PU25']]

@fabiocos Could you please comment on the implementation? Thanks.

@amassiro
Copy link
Contributor Author

amassiro commented Oct 8, 2019

The customization is almost ready.

I am facing the following problem:

----- Begin Fatal Exception 08-Oct-2019 18:34:25 CEST-----------------------
An exception of category 'ConditionDatabase' occurred while
[0] Processing Event run: 1 lumi: 1 event: 7 stream: 1
[1] Running path 'HLTAnalyzerEndpath'
[2] Prefetching for module L1TRawToDigi/'hltGtStage2Digis'
[3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
[4] Prefetching for module SiStripDigiToRawModule/'SiStripDigiToRaw'
[5] Calling method for module PreMixingModule/'mixData'
[6] Using EventSetup component EcalLaserCorrectionServiceMC/'' to make data EcalLaserDbServiceMC/'' in record EcalLaserDbRecordMC
[7] Using EventSetup component PoolDBESSource/'GlobalTag' to make data EcalLaserAPDPNRatiosMC/'' in record EcalLaserAPDPNRatiosMCRcd
Exception Message:
Payload of type EcalLaserAPDPNRatios with id 0ee6722fdf42ab0d7d4c78ec4f40c0159789bbaf could not be loaded. An exception of category 'ConditionDatabase' occurred.
Exception Message:
De-serialization failed: An exception of category 'ConditionDatabase' occurred.
Exception Message:
Type mismatch, user type: "EcalLaserAPDPNRatiosMC", target type: "EcalLaserAPDPNRatios" from createPayload
Payload serialization info: {
"CMSSW_version": "CMSSW_9_2_4",
"architecture": "slc6_amd64_gcc530",
"technology": "boost/serialization",
"tech_version": "1_63"
}
from default_deserialize
from Session::fetchPayload
----- End Fatal Exception -------------------------------------------------

This PR requires a new object in the DB ("EcalLaserAPDPNRatiosMC"), however, being in the same format of "EcalLaserAPDPNRatios" I managed in the past to test the code by using "EcalLaserAPDPNRatios" with the following workaround:

process.GlobalTag.toGet = cms.VPSet(
cms.PSet( record = cms.string("EcalLaserAPDPNRatiosMCRcd"),
tag = cms.string("EcalLaserAPDPNRatios_UL_2017_mc"),
connect = cms.string("frontier://FrontierProd/CMS_CONDITIONS")
)
)

but unfortunately this does not work anymore here.

Do you have any suggestion? Should we get the new object in the db first? Is any workaround available for testing purposes?

@srimanob
Copy link
Contributor

srimanob commented Oct 8, 2019

I think you can do
--customise_commands "process.EcalLaserCorrectionServiceMC = cms.ESProducer("EcalLaserCorrectionServiceMC")\n process.GlobalTag.toGet = cms.VPSet(cms.PSet( record = cms.string("EcalLaserAPDPNRatiosMCRcd"),tag = cms.string("EcalLaserAPDPNRatios_UL_2017_mc"),connect = cms.string("frontier://FrontierProd/CMS_CONDITIONS")))"

@amassiro
Copy link
Contributor Author

amassiro commented Oct 8, 2019

The problem is that also with

process.GlobalTag.toGet = cms.VPSet(
cms.PSet( record = cms.string("EcalLaserAPDPNRatiosMCRcd"),
tag = cms.string("EcalLaserAPDPNRatios_UL_2017_mc"),
connect = cms.string("frontier://FrontierProd/CMS_CONDITIONS")
)
)

I get the error aforementioned, while in 10_6 I was not getting it ...

Do you know if anything changed on DB side?

@srimanob
Copy link
Contributor

srimanob commented Oct 8, 2019

@ggovi @tocheng @tlampen @christopheralanwest
Could you please help on this?
Is it possible to create an object on the fly, which its format is the same of existing object. So we don't need to touch DB for the first test.

@srimanob
Copy link
Contributor

srimanob commented Oct 9, 2019

Hi @amassiro
I try to follow your PR, but when I run, I get core dump (*). It does not point me to the issue you show. Do I miss anything. I will recheck again if what I have in my test directory is the same as your PR. I tested based on 11_0_0_pre9.

(*)
A fatal system signal has occurred: segmentation violation
The following is the call stack containing the origin of the signal.

Wed Oct 9 00:25:38 CEST 2019
Thread 2 (Thread 0x7f6094f4f700 (LWP 27515)):
#0 0x00007f60af513179 in waitpid () from /lib64/libpthread.so.0
#1 0x00007f60a2f43f57 in edm::service::cmssw_stacktrace_fork() () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/pluginFWCoreServicesPlugins.so
#2 0x00007f60a2f44a1a in edm::service::InitRootHandlers::stacktraceHelperThread() () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/pluginFWCoreServicesPlugins.so
#3 0x00007f60afaf7ccf in execute_native_thread_routine () at ../../../../../libstdc++-v3/src/c++11/thread.cc:80
#4 0x00007f60af50bdd5 in start_thread () from /lib64/libpthread.so.0
#5 0x00007f60af23502d in clone () from /lib64/libc.so.6
Thread 1 (Thread 0x7f60ad6e14c0 (LWP 27472)):
#0 0x00007f60af22a38d in poll () from /lib64/libc.so.6
#1 0x00007f60a2f443bf in full_read.constprop () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/pluginFWCoreServicesPlugins.so
#2 0x00007f60a2f44afc in edm::service::InitRootHandlers::stacktraceFromThread() () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/pluginFWCoreServicesPlugins.so
#3 0x00007f60a2f459d9 in sig_dostack_then_abort () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/pluginFWCoreServicesPlugins.so
#4
#5 0x00007f608eded4e0 in EcalSignalGenerator::samplesInPE(EBDataFrame const&) () from /afs/cern.ch/work/s/srimanob/test/RunDependent/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/libSimCalorimetryEcalSimAlgos.so
#6 0x00007f60804f39f8 in EcalSignalGenerator::fill(edm::ModuleCallingContext const*) () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/pluginSimCalorimetryEcalSimProducersPlugins.so
#7 0x00007f60804ea831 in PreMixingEcalWorker::addPileups(PileUpEventPrincipal const&, edm::EventSetup const&) () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/pluginSimCalorimetryEcalSimProducersPlugins.so
#8 0x00007f6080514c20 in edm::PreMixingModule::pileWorker(edm::EventPrincipal const&, int, int, edm::EventSetup const&, edm::ModuleCallingContext const*, edm::PreMixingModule::AdjustPileupDistribution const*) () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/pluginSimGeneralPreMixingModulePlugins.so
#9 0x00007f60805198ae in unsigned long edm::VectorInputSource::loopOverEvents<edm::RecordEventID<std::_Bind<bool (edm::PreMixingModule::(std::reference_wrapperedm::PreMixingModule, std::_Placeholder<1>, int, std::_Placeholder<2>, std::reference_wrapper<edm::EventSetup const>, edm::ModuleCallingContext const, edm::PreMixingModule::AdjustPileupDistribution const*))(edm::EventPrincipal const&, int, int, edm::EventSetup const&, edm::ModuleCallingContext const*, edm::PreMixingModule::AdjustPileupDistribution const*)> > >(edm::EventPrincipal&, unsigned long&, unsigned long, edm::RecordEventID<std::_Bind<bool (edm::PreMixingModule::(std::reference_wrapperedm::PreMixingModule, std::_Placeholder<1>, int, std::_Placeholder<2>, std::reference_wrapper<edm::EventSetup const>, edm::ModuleCallingContext const, edm::PreMixingModule::AdjustPileupDistribution const*))(edm::EventPrincipal const&, int, int, edm::EventSetup const&, edm::ModuleCallingContext const*, edm::PreMixingModule::AdjustPileupDistribution const*)> >, CLHEP::HepRandomEngine*, edm::EventID const*, bool) () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/pluginSimGeneralPreMixingModulePlugins.so
#10 0x00007f60805199f7 in void edm::PileUp::readPileUp<std::_Bind<bool (edm::PreMixingModule::(std::reference_wrapperedm::PreMixingModule, std::_Placeholder<1>, int, std::_Placeholder<2>, std::reference_wrapper<edm::EventSetup const>, edm::ModuleCallingContext const, edm::PreMixingModule::AdjustPileupDistribution const*))(edm::EventPrincipal const&, int, int, edm::EventSetup const&, edm::ModuleCallingContext const*, edm::PreMixingModule::AdjustPileupDistribution const*)> >(edm::EventID const&, std::vector<edm::SecondaryEventIDAndFileInfo, std::allocatoredm::SecondaryEventIDAndFileInfo >&, std::_Bind<bool (edm::PreMixingModule::(std::reference_wrapperedm::PreMixingModule, std::_Placeholder<1>, int, std::_Placeholder<2>, std::reference_wrapper<edm::EventSetup const>, edm::ModuleCallingContext const, edm::PreMixingModule::AdjustPileupDistribution const*))(edm::EventPrincipal const&, int, int, edm::EventSetup const&, edm::ModuleCallingContext const*, edm::PreMixingModule::AdjustPileupDistribution const*)>, int, edm::StreamID const&) () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/pluginSimGeneralPreMixingModulePlugins.so
#11 0x00007f6080515a51 in edm::PreMixingModule::doPileUp(edm::Event&, edm::EventSetup const&) () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/pluginSimGeneralPreMixingModulePlugins.so
#12 0x00007f6080780020 in edm::BMixingModule::produce(edm::Event&, edm::EventSetup const&) () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/libMixingBase.so
#13 0x00007f60b1dc7181 in edm::stream::EDProducerAdaptorBase::doEvent(edm::EventPrincipal const&, edm::EventSetupImpl const&, edm::ActivityRegistry*, edm::ModuleCallingContext const*) () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/libFWCoreFramework.so
#14 0x00007f60b1cfe1b3 in edm::WorkerTedm::stream::EDProducerAdaptorBase::implDo(edm::EventPrincipal const&, edm::EventSetupImpl const&, edm::ModuleCallingContext const*) () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/libFWCoreFramework.so
#15 0x00007f60b1c946aa in decltype ({parm#1}()) edm::convertException::wrap<bool edm::Worker::runModule<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >(edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::MyPrincipal const&, edm::EventSetupImpl const&, edm::StreamID, edm::ParentContext const&, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::Context const*)::{lambda()#1}>(bool edm::Worker::runModule<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >(edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::MyPrincipal const&, edm::EventSetupImpl const&, edm::StreamID, edm::ParentContext const&, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::Context const*)::{lambda()#1}) () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/libFWCoreFramework.so
#16 0x00007f60b1c9487e in bool edm::Worker::runModule<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >(edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::MyPrincipal const&, edm::EventSetupImpl const&, edm::StreamID, edm::ParentContext const&, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::Context const*) () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/libFWCoreFramework.so
#17 0x00007f60b1c95fdb in std::__exception_ptr::exception_ptr edm::Worker::runModuleAfterAsyncPrefetch<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >(std::__exception_ptr::exception_ptr const*, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::MyPrincipal const&, edm::EventSetupImpl const&, edm::StreamID, edm::ParentContext const&, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::Context const*) () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/libFWCoreFramework.so
#18 0x00007f60b1c96ff4 in edm::Worker::RunModuleTask<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >::execute() () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/libFWCoreFramework.so
#19 0x00007f60b04df8a1 in tbb::internal::custom_schedulertbb::internal::IntelSchedulerTraits::local_wait_for_all (this=0x7f60ac163200, parent=..., child=) at ../../src/tbb/scheduler.cpp:1016
#20 0x00007f60b1d72045 in edm::EventProcessor::processLumis(std::shared_ptr const&) () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/libFWCoreFramework.so
#21 0x00007f60b1d79bce in edm::EventProcessor::runToCompletion() () from /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_0_pre9/lib/slc7_amd64_gcc820/libFWCoreFramework.so
#22 0x0000000000410c7b in main::{lambda()#1}::operator()() const ()
#23 0x000000000040f2e2 in main ()

Current Modules:

Module: PreMixingModule:mixData (crashed)

A fatal system signal has occurred: segmentation violation
Segmentation fault (core dumped)
(258) PyReleaseValidation/test/250202.172_TTbar_13UP17+TTbar_13UP17+DIGIPRMXUP17_PU25_RD+RECOPRMXUP17_PU25+HARVESTUP17_PU25: packet_write_wait: Connection to 137.138.123.16 port 22: Broken pipe

@ggovi
Copy link
Contributor

ggovi commented Oct 9, 2019

@amassiro
No change has been introduced in the DB code from 10_6_X to 11_0_X. On the other hand, I don't see how you can read an object of type "EcalLaserAPDPNRatios" ( see https://cms-conddb-prod.cern.ch/cmsDbBrowser/list/Prod/tags/EcalLaserAPDPNRatios_UL_2017_mc )
as a type "EcalLaserAPDPNRatiosMC" - which is exactly the error message you are getting here. If the two class layouts are equal, just use the first class...

@amassiro
Copy link
Contributor Author

amassiro commented Oct 9, 2019

@amassiro
No change has been introduced in the DB code from 10_6_X to 11_0_X. On the other hand, I don't see how you can read an object of type "EcalLaserAPDPNRatios" ( see https://cms-conddb-prod.cern.ch/cmsDbBrowser/list/Prod/tags/EcalLaserAPDPNRatios_UL_2017_mc )
as a type "EcalLaserAPDPNRatiosMC" - which is exactly the error message you are getting here. If the two class layouts are equal, just use the first class...

We don't have yet the object "EcalLaserAPDPNRatiosMC" in the DB, but it will have to be included later.
The object "EcalLaserAPDPNRatiosMC" is needed by the code and has to be different from "EcalLaserAPDPNRatios".

In CMSSW_10_6_0 I was able to do the workaround of mapping the tag "EcalLaserAPDPNRatios_UL_2017_mc" into the record "EcalLaserAPDPNRatiosMCRcd".

I will try to investigate further the origin of the error messages I am getting.

@srimanob : I don't know why you are getting the "segmentation violation" ... I am building currently on top of CMSSW_11_0_X_2019-10-06-2300
Once the previous error is fixed I will rebase to the master again.

@@ -172,6 +175,7 @@ REGISTER_PLUGIN(EcalIntercalibErrorsRcd, EcalCondObjectContainer<float>);
REGISTER_PLUGIN(EcalADCToGeVConstantRcd, EcalADCToGeVConstant);
REGISTER_PLUGIN(EcalLaserAlphasRcd, EcalCondObjectContainer<float>);
REGISTER_PLUGIN(EcalLaserAPDPNRatiosRcd, EcalLaserAPDPNRatios);
REGISTER_PLUGIN(EcalLaserAPDPNRatiosMCRcd, EcalLaserAPDPNRatiosMC);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amassiro this line is instructing the Framework to read the payloads of the tag "EcalLaserAPDPNRatios_UL_2017_mc" as "EcalLaserAPDPNRatiosMC" objects. No way to make this working.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amassiro I mean, the line in itself is fine, but you need to read payloads of type "EcalLaserAPDPNRatiosMC"

@amassiro
Copy link
Contributor Author

New PR, namely #28214, with all the fixes implemented cleanly (after an iteration via email, thanks db expert!)

@fabiocos
Copy link
Contributor

@amassiro so can this PR be closed, as it is superseded by the new one?

@amassiro
Copy link
Contributor Author

@amassiro so can this PR be closed, as it is superseded by the new one?

Yes, this is superseded by #28214

@amassiro amassiro closed this Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants