Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data and MC global tags for 2018 UL #27923

Merged
merged 5 commits into from
Sep 4, 2019

Conversation

christopheralanwest
Copy link
Contributor

@christopheralanwest christopheralanwest commented Sep 3, 2019

PR description:

This PR includes global tags for the 2018 ultra-legacy reprocessing that are intended to be final. An unrelated change to the Run 3 prompt GT is included; this change is purely technical and will not affect any workflow.

Offline GT
Complete set of conditions for 2018UL. Includes updates to beamspot [1-2], tracker alignment [3-5], muon alignment [6-7], ECAL calibrations [8] and a fix for pixel conditions for a single fill with modified HV settings [9].

Diffs:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_v5/110X_dataRun2_v6
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_relval_v5/110X_dataRun2_relval_v6

[1] https://indico.cern.ch/event/840920/#35-ul-2018-sign-off-of-beamspo
[2] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4213/1/1/1.html
[3] https://indico.cern.ch/event/837619/#10-ul-2018-tracker-alignment-s
[4] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4205.html
[5] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4205/1/1.html
[6] https://indico.cern.ch/event/839963/#33-global-position-record-for
[7] https://indico.cern.ch/event/840920/#34-ul-2018-sign-off-for-muon-a
[8] https://indico.cern.ch/event/840920/#38-ecal-sign-off-for-ultra-leg
[9] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4197.html

Prompt-like GTs

Updated PPS conditions for consistency with 2018 UL. The prompt-like GTs are updated as well because the PPS diamond was introduced after the completion of 2018 prompt reco. A payload is needed to avoid crashes in prompt-like workflows and so we have chosen to use payloads consistent with the offline GT.

Diffs:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_PromptLike_HEfail_v3/110X_dataRun2_PromptLike_HEfail_v5
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_PromptLike_v3/110X_dataRun2_PromptLike_v5
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_PromptLike_HI_v3/110X_dataRun2_PromptLike_HI_v5

2018 MC
Complete set of conditions for 2018UL. Updated tracker alignment scenario and APEs [1]

[1] https://indico.cern.ch/event/840920/#36-ul-2018-sign-off-for-mc-tra

Diffs:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018_realistic_v3/110X_upgrade2018_realistic_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018_realistic_HEfail_v3/110X_upgrade2018_realistic_HEfail_v4

Run 3 prompt
Change to EcalADCToGeVConstantRcd tag populated by O2O [1]

[1] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4191.html

Diff:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun3_Prompt_v2/106X_dataRun3_Prompt_v3

PR validation:

For physics validation, please see above. Also, as a technical test, ran runTheMatrix.py -l limited -i all --ibeos

if this PR is a backport please specify the original PR:

Not a backport but will be backported to 10_6_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27923/11753

  • This PR adds an extra 12KB to repository

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2342/console Started: 2019/09/03 23:57

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2019

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2019

-1

Tested at: 48a23b2

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47e69c/2342/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Wed Sep 4 01:20:13 2019-date Wed Sep 4 01:13:54 2019 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Wed Sep 4 01:20:26 2019-date Wed Sep 4 01:14:15 2019 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Wed Sep 4 01:25:55 2019-date Wed Sep 4 01:14:34 2019 s - exit: 16640

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2019

Comparison job queued.

@christopheralanwest
Copy link
Contributor Author

There is a problem with the tag PPSDiamondTimingCalibration_2017_2018_prompt_v1 in the promptlike global tag. The errors in the three failing tests are equivalent:

----- Begin Fatal Exception 04-Sep-2019 01:19:56 CEST-----------------------
An exception of category 'WrongNumParameters' occurred while
   [0] Processing  Event run: 295606 lumi: 1 event: 37589 stream: 3
   [1] Running path 'reconstruction_step'
   [2] Calling method for module CTPPSDiamondRecHitProducer/'ctppsDiamondRecHits'
Exception Message:
FormulaEvaluator expected at least 4 but was passed only 0
----- End Fatal Exception -------------------------------------------------

I will follow up with PPS experts.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47e69c/2342/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5454 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2955700
  • DQMHistoTests: Total failures: 5852
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 2949500
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.016 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 136.85 ): 0.016 KiB JetMET/SUSYDQM
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27923/11761

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2019

Pull request #27923 was updated. @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please check and sign again.

@christopheralanwest
Copy link
Contributor Author

please test workflow 138.1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2358/console Started: 2019/09/04 16:28

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47e69c/2358/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-47e69c/138.1_RunCosmics2019+RunCosmics2019+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5406 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2955700
  • DQMHistoTests: Total failures: 5676
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 2949677
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.016 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 136.85 ): 0.016 KiB JetMET/SUSYDQM
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

  • Comparison test differences seen only in 2018 data and MC workflows
  • Payloads have been validated individually by subdetector experts, as described in the introduction to this PR

@fabiocos @kpedro88 I suggest merging this PR prior to building 11_0_0_pre7 so that the global tag updates that complete the 2018 UL preparation enter the standard release validation

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Sep 4, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants