Fix 5 warnings in PhysicsTools/MVATrainer

[mrodozov]

PR description:

Fixes gcc9 warnings

PR validation:

Builds without warnings.

[mrodozov]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27870/11625

• This PR adds an extra 28KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2179/console Started: 2019/08/26 12:43

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

PhysicsTools/MVATrainer

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@emilbols, @smoortga, @acaudron, @HeinerTholen, @JyothsnaKomaragiri, @mverzett, @ferencek, @andrzejnovak, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[guitargeek]

H! Don't you think it would be better to just delete that package? I did some background research on that package some time ago, and it's even older than TMVA. IMHO there is not point in supporting that code and spending time fixing bugs here. Everyone is now either using TMVA or the Python data science ecosystem to train their MVAs.

The only remaining use of that package is within the TopQuarkAnalysis subsystem, where a few tweaks are needed to remove the dependence [1]. It's probably okay to remove the bits of code there that depend on the MVATrainer, as I doubt the TopQuarkAnalysis subsystem is used (seems to date back even to Tevatron times).

What do you think?

[1] master...guitargeek:MVATrainer

[cmsbuild]

+1
Tested at: d1d299d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa1ab9/2179/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa1ab9/2179/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939165
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[mrodozov]

would you confirm that's the difference
master...guitargeek:MVATrainer ?
because the other link doesn't show any difference (github has its issues)
Then I can rework the PR

[guitargeek]

Yes you are right. Thanks, I updated the link in my post.

Alright then, I will do a PR with the removal of the package and refer to your gcc warnings PR to exemplify how leaving the MVATrainer in the release can be annoying because it raises new warnings for every major gcc version bump. Can you please leave this PR open until the release managers decided if they want to remove the package or not? Do you agree with this procedure?

[mrodozov]

Can you please leave this PR open until the release managers decided if they want to remove the package or not? Do you agree with this procedure?

Yes it fine with me.

[fabiocos]

@santocch I do not see why this should not be a break, could you please cross check?

[fabiocos]

hold

this PR becomes obsolete if #27888 is integrated

[cmsbuild]

Pull request has been put on hold by @fabiocos
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[fabiocos]

@mrodozov now that #27888 has been integrated this PR can be closed