-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Skewed Phase 2 Inner Tracker geometry (T16). #27824
Changes from 7 commits
d89e73b
793b2e3
131c629
79de561
724213f
b245d6b
ce63120
0ecac76
8d7d067
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
from Configuration.Eras.Era_Phase2C9_cff import Phase2C9 | ||
from Configuration.Eras.Modifier_phase2_hfnose_cff import phase2_hfnose | ||
|
||
Phase2C10 = cms.ModifierChain(Phase2C9, phase2_hfnose) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
from Configuration.Eras.Era_Phase2C10_cff import Phase2C10 | ||
from Configuration.Eras.Modifier_phase2_timing_cff import phase2_timing | ||
|
||
Phase2C10_timing = cms.ModifierChain(Phase2C10, phase2_timing) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
from Configuration.Eras.Era_Phase2C10_timing_cff import Phase2C10_timing | ||
from Configuration.Eras.Modifier_phase2_timing_layer_cff import phase2_timing_layer | ||
from Configuration.Eras.Modifier_phase2_timing_layer_bar_cff import phase2_timing_layer_bar | ||
|
||
Phase2C10_timing_layer_bar = cms.ModifierChain(Phase2C10_timing, phase2_timing_layer, phase2_timing_layer_bar) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
# This config was generated automatically using generate2026Geometry.py | ||
# If you notice a mistake, please update the generating script, not just this config | ||
|
||
from Configuration.Geometry.GeometryExtended2026D47_cff import * | ||
|
||
# tracker | ||
from Geometry.CommonDetUnit.globalTrackingGeometry_cfi import * | ||
from RecoTracker.GeometryESProducer.TrackerRecoGeometryESProducer_cfi import * | ||
from Geometry.TrackerGeometryBuilder.trackerParameters_cfi import * | ||
from Geometry.TrackerNumberingBuilder.trackerTopology_cfi import * | ||
from Geometry.TrackerGeometryBuilder.idealForDigiTrackerGeometry_cff import * | ||
trackerGeometry.applyAlignment = cms.bool(False) | ||
|
||
# calo | ||
from Geometry.CaloEventSetup.HGCalV9Topology_cfi import * | ||
from Geometry.HGCalGeometry.HGCalGeometryESProducer_cfi import * | ||
from Geometry.CaloEventSetup.HFNoseTopology_cfi import * | ||
from Geometry.ForwardGeometry.HFNoseGeometryESProducer_cfi import * | ||
from Geometry.CaloEventSetup.CaloTopology_cfi import * | ||
from Geometry.CaloEventSetup.CaloGeometryBuilder_cfi import * | ||
CaloGeometryBuilder = cms.ESProducer("CaloGeometryBuilder", | ||
SelectedCalos = cms.vstring("HCAL", | ||
"ZDC", | ||
"EcalBarrel", | ||
"TOWER", | ||
"HGCalEESensitive", | ||
"HGCalHESiliconSensitive", | ||
"HGCalHEScintillatorSensitive", | ||
"HGCalHFNoseSensitive", | ||
) | ||
) | ||
from Geometry.EcalAlgo.EcalBarrelGeometry_cfi import * | ||
from Geometry.HcalEventSetup.HcalGeometry_cfi import * | ||
from Geometry.HcalEventSetup.CaloTowerGeometry_cfi import * | ||
from Geometry.HcalEventSetup.CaloTowerTopology_cfi import * | ||
from Geometry.HcalCommonData.hcalDDDRecConstants_cfi import * | ||
from Geometry.HcalEventSetup.hcalTopologyIdeal_cfi import * | ||
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import * | ||
from Geometry.EcalMapping.EcalMapping_cfi import * | ||
from Geometry.EcalMapping.EcalMappingRecord_cfi import * | ||
|
||
# muon | ||
from Geometry.MuonNumbering.muonNumberingInitialization_cfi import * | ||
from RecoMuon.DetLayers.muonDetLayerGeometry_cfi import * | ||
from Geometry.GEMGeometryBuilder.gemGeometry_cfi import * | ||
from Geometry.GEMGeometryBuilder.me0Geometry_cfi import * | ||
from Geometry.CSCGeometryBuilder.idealForDigiCscGeometry_cff import * | ||
from Geometry.DTGeometryBuilder.idealForDigiDtGeometry_cff import * | ||
|
||
# forward | ||
from Geometry.ForwardGeometry.ForwardGeometry_cfi import * | ||
|
||
# timing | ||
from RecoMTD.DetLayers.mtdDetLayerGeometry_cfi import * | ||
from Geometry.MTDGeometryBuilder.mtdParameters_cfi import * | ||
from Geometry.MTDNumberingBuilder.mtdNumberingGeometry_cfi import * | ||
from Geometry.MTDNumberingBuilder.mtdTopology_cfi import * | ||
from Geometry.MTDGeometryBuilder.mtdGeometry_cfi import * | ||
from Geometry.MTDGeometryBuilder.idealForDigiMTDGeometry_cff import * | ||
mtdGeometry.applyAlignment = cms.bool(False) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
# This config was generated automatically using generate2026Geometry.py | ||
# If you notice a mistake, please update the generating script, not just this config | ||
|
||
from Geometry.CMSCommonData.cmsExtendedGeometry2026D47XML_cfi import * | ||
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import * | ||
from SLHCUpgradeSimulations.Geometry.fakeConditions_phase2TkT14_cff import * | ||
from Geometry.HcalCommonData.hcalParameters_cfi import * | ||
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import * | ||
from Geometry.HGCalCommonData.hgcalParametersInitialization_cfi import * | ||
from Geometry.HGCalCommonData.hgcalNumberingInitialization_cfi import * | ||
from Geometry.ForwardCommonData.hfnoseParametersInitialization_cfi import * | ||
from Geometry.ForwardCommonData.hfnoseNumberingInitialization_cfi import * | ||
|
||
from Geometry.MTDNumberingBuilder.mtdNumberingGeometry_cfi import * |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
# This config was generated automatically using generate2026Geometry.py | ||
# If you notice a mistake, please update the generating script, not just this config | ||
|
||
from Configuration.Geometry.GeometryExtended2026D48_cff import * | ||
|
||
# tracker | ||
from Geometry.CommonDetUnit.globalTrackingGeometry_cfi import * | ||
from RecoTracker.GeometryESProducer.TrackerRecoGeometryESProducer_cfi import * | ||
from Geometry.TrackerGeometryBuilder.trackerParameters_cfi import * | ||
from Geometry.TrackerNumberingBuilder.trackerTopology_cfi import * | ||
from Geometry.TrackerGeometryBuilder.idealForDigiTrackerGeometry_cff import * | ||
trackerGeometry.applyAlignment = cms.bool(False) | ||
|
||
# calo | ||
from Geometry.CaloEventSetup.HGCalV9Topology_cfi import * | ||
from Geometry.HGCalGeometry.HGCalGeometryESProducer_cfi import * | ||
from Geometry.CaloEventSetup.HFNoseTopology_cfi import * | ||
from Geometry.ForwardGeometry.HFNoseGeometryESProducer_cfi import * | ||
from Geometry.CaloEventSetup.CaloTopology_cfi import * | ||
from Geometry.CaloEventSetup.CaloGeometryBuilder_cfi import * | ||
CaloGeometryBuilder = cms.ESProducer("CaloGeometryBuilder", | ||
SelectedCalos = cms.vstring("HCAL", | ||
"ZDC", | ||
"EcalBarrel", | ||
"TOWER", | ||
"HGCalEESensitive", | ||
"HGCalHESiliconSensitive", | ||
"HGCalHEScintillatorSensitive", | ||
"HGCalHFNoseSensitive", | ||
) | ||
) | ||
from Geometry.EcalAlgo.EcalBarrelGeometry_cfi import * | ||
from Geometry.HcalEventSetup.HcalGeometry_cfi import * | ||
from Geometry.HcalEventSetup.CaloTowerGeometry_cfi import * | ||
from Geometry.HcalEventSetup.CaloTowerTopology_cfi import * | ||
from Geometry.HcalCommonData.hcalDDDRecConstants_cfi import * | ||
from Geometry.HcalEventSetup.hcalTopologyIdeal_cfi import * | ||
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import * | ||
from Geometry.EcalMapping.EcalMapping_cfi import * | ||
from Geometry.EcalMapping.EcalMappingRecord_cfi import * | ||
|
||
# muon | ||
from Geometry.MuonNumbering.muonNumberingInitialization_cfi import * | ||
from RecoMuon.DetLayers.muonDetLayerGeometry_cfi import * | ||
from Geometry.GEMGeometryBuilder.gemGeometry_cfi import * | ||
from Geometry.GEMGeometryBuilder.me0Geometry_cfi import * | ||
from Geometry.CSCGeometryBuilder.idealForDigiCscGeometry_cff import * | ||
from Geometry.DTGeometryBuilder.idealForDigiDtGeometry_cff import * | ||
|
||
# forward | ||
from Geometry.ForwardGeometry.ForwardGeometry_cfi import * | ||
|
||
# timing | ||
from RecoMTD.DetLayers.mtdDetLayerGeometry_cfi import * | ||
from Geometry.MTDGeometryBuilder.mtdParameters_cfi import * | ||
from Geometry.MTDNumberingBuilder.mtdNumberingGeometry_cfi import * | ||
from Geometry.MTDNumberingBuilder.mtdTopology_cfi import * | ||
from Geometry.MTDGeometryBuilder.mtdGeometry_cfi import * | ||
from Geometry.MTDGeometryBuilder.idealForDigiMTDGeometry_cff import * | ||
mtdGeometry.applyAlignment = cms.bool(False) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
# This config was generated automatically using generate2026Geometry.py | ||
# If you notice a mistake, please update the generating script, not just this config | ||
|
||
from Geometry.CMSCommonData.cmsExtendedGeometry2026D48XML_cfi import * | ||
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import * | ||
from SLHCUpgradeSimulations.Geometry.fakeConditions_phase2TkT14_cff import * | ||
from Geometry.HcalCommonData.hcalParameters_cfi import * | ||
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import * | ||
from Geometry.HGCalCommonData.hgcalParametersInitialization_cfi import * | ||
from Geometry.HGCalCommonData.hgcalNumberingInitialization_cfi import * | ||
from Geometry.ForwardCommonData.hfnoseParametersInitialization_cfi import * | ||
from Geometry.ForwardCommonData.hfnoseNumberingInitialization_cfi import * | ||
|
||
from Geometry.MTDNumberingBuilder.mtdNumberingGeometry_cfi import * |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,6 +36,10 @@ | |
'2026D45PU', | ||
'2026D46', | ||
'2026D46PU', | ||
'2026D47', | ||
'2026D47PU', | ||
'2026D48', | ||
'2026D48PU', | ||
] | ||
|
||
# pre-generation of WF numbers | ||
|
@@ -358,6 +362,20 @@ | |
'Era' : 'Phase2C9_timing_layer_bar', | ||
'ScenToRun' : ['GenSimHLBeamSpotFull','DigiFullTrigger','RecoFullGlobal', 'HARVESTFullGlobal'], | ||
}, | ||
'2026D47' : { | ||
'Geom' : 'Extended2026D47', | ||
'HLTmenu': '@fake2', | ||
'GT' : 'auto:phase2_realistic_T15', | ||
'Era' : 'Phase2C10_timing_layer_bar', | ||
'ScenToRun' : ['GenSimHLBeamSpotFull','DigiFullTrigger','RecoFullGlobal', 'HARVESTFullGlobal'], | ||
}, | ||
'2026D48' : { | ||
'Geom' : 'Extended2026D48', | ||
'HLTmenu': '@fake2', | ||
'GT' : 'auto:phase2_realistic_T15', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. will there need to be a separate GT for T16? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kpedro88 there is no need for it at the moment. As the list of |
||
'Era' : 'Phase2C9_timing_layer_bar', | ||
'ScenToRun' : ['GenSimHLBeamSpotFull','DigiFullTrigger','RecoFullGlobal', 'HARVESTFullGlobal'], | ||
}, | ||
} | ||
|
||
# standard PU sequences | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think a tracker test workflow needs to include the HF nose. I would make either D45 or D46 the basis for D48.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are C10 and F3 not the latest descriptions available?
In that case, why not having the latest Tracker description with them, and compare D48 versus D47?
It would avoid having latest subdetectorA with old subdetectorB and latest subdetectorB with old subdetectorA. Which would imply that when one wants to access the latest available CMS geometry, it does not exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C10 and F3 are the latest version of the HF nose. This is a detector R&D effort that is not yet an approved part of the Phase 2 upgrade project. Combining tracker tests with this will just lead to confusion and inconsistencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha I didn't know C10 and F3 were purely in an hypothetical state for now.
Ok I will simply revert my last commit then.