HGCAL: 1st version of hadronic reconstruction #27819

gouskos · 2019-08-22T11:34:02Z

PR description:

add the first version of the hadronic shower reconstruction. NB. Parameters need further tuning [work in progress]
Introduce the "Out-In" step for the Trackster creation. Currently enabled by default for both EM and HAD reconstruction. Compatibility angles between Layer clusters can be tuned separately for the "In-Out" and "Out-In" steps.
Use at least 2 cells to form a Layer cluster in the Silicon part [more robust against noise, less combinatorial background]. For the Scintillator part the requirement is relaxed to 1 cell

PR validation:

First validation of the changes can be found in the following links:

cmsbuild · 2019-08-22T11:35:43Z

The code-checks are being triggered in jenkins.

felicepantaleo · 2019-08-22T11:39:58Z

@rovere @amartelli fyi

cmsbuild · 2019-08-22T11:41:22Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27819/11541

This PR adds an extra 72KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoHGCal/TICL/plugins/HGCDoublet.cc modified in PR(s): HGCAL TICL seeded iteration #27439
- File RecoHGCal/TICL/plugins/HGCDoublet.h modified in PR(s): HGCAL TICL seeded iteration #27439
- File RecoHGCal/TICL/plugins/HGCGraph.cc modified in PR(s): HGCAL TICL seeded iteration #27439
- File RecoHGCal/TICL/plugins/HGCGraph.h modified in PR(s): HGCAL TICL seeded iteration #27439
- File RecoHGCal/TICL/plugins/PatternRecognitionbyCA.cc modified in PR(s): Add energy regression and particle identification to RecoHGCal/TICL. #27634, HGCAL TICL seeded iteration #27439
- File RecoHGCal/TICL/plugins/PatternRecognitionbyCA.h modified in PR(s): Add energy regression and particle identification to RecoHGCal/TICL. #27634, HGCAL TICL seeded iteration #27439
- File RecoHGCal/TICL/plugins/TrackstersProducer.cc modified in PR(s): Add energy regression and particle identification to RecoHGCal/TICL. #27634, HGCAL TICL seeded iteration #27439
- File RecoHGCal/TICL/python/ticl_iterations.py modified in PR(s): HGCAL TICL seeded iteration #27439

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27819/11541/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27819/11541/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

slava77 · 2019-08-22T13:42:28Z

@gouskos
please note that you have to resolve issues with the code in #27819 (comment)
before we can start the compile and run time tests

cmsbuild · 2019-08-22T13:49:31Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-08-22T13:56:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27819/11543

This PR adds an extra 72KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoHGCal/TICL/plugins/HGCDoublet.cc modified in PR(s): HGCAL TICL seeded iteration #27439
- File RecoHGCal/TICL/plugins/HGCDoublet.h modified in PR(s): HGCAL TICL seeded iteration #27439
- File RecoHGCal/TICL/plugins/HGCGraph.cc modified in PR(s): HGCAL TICL seeded iteration #27439
- File RecoHGCal/TICL/plugins/HGCGraph.h modified in PR(s): HGCAL TICL seeded iteration #27439
- File RecoHGCal/TICL/plugins/PatternRecognitionbyCA.cc modified in PR(s): Add energy regression and particle identification to RecoHGCal/TICL. #27634, HGCAL TICL seeded iteration #27439
- File RecoHGCal/TICL/plugins/PatternRecognitionbyCA.h modified in PR(s): Add energy regression and particle identification to RecoHGCal/TICL. #27634, HGCAL TICL seeded iteration #27439
- File RecoHGCal/TICL/plugins/TrackstersProducer.cc modified in PR(s): Add energy regression and particle identification to RecoHGCal/TICL. #27634, HGCAL TICL seeded iteration #27439
- File RecoHGCal/TICL/python/ticl_iterations.py modified in PR(s): HGCAL TICL seeded iteration #27439

cmsbuild · 2019-08-22T13:57:00Z

A new Pull Request was created by @gouskos for master.

It involves the following packages:

RecoHGCal/TICL

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @clelange, @hatakeyamak this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

gouskos · 2019-08-22T14:02:19Z

@gouskos
please note that you have to resolve issues with the code in #27819 (comment)
before we can start the compile and run time tests

@slava77 Fixed now - sorry

perrotta · 2019-08-22T14:18:40Z

please test

cmsbuild · 2019-08-22T14:19:13Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2115/console Started: 2019/08/22 16:19

clelange · 2019-08-22T14:36:00Z

@steggema FYI

cmsbuild · 2019-08-22T15:31:38Z

+1
Tested at: dfd6dd8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d0c01/2115/summary.html

cmsbuild · 2019-08-22T15:31:42Z

Comparison job queued.

cmsbuild · 2019-09-11T08:23:41Z

Pull request #27819 was updated. @perrotta, @cmsbuild, @kpedro88, @slava77 can you please check and sign again.

felicepantaleo · 2019-09-11T08:50:54Z

please test workflow 20493.52

cmsbuild · 2019-09-11T08:51:23Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2479/console Started: 2019/09/11 11:40

cmsbuild · 2019-09-11T11:29:09Z

+1
Tested at: 1dc050c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d0c01/2479/summary.html

cmsbuild · 2019-09-11T11:29:13Z

Comparison job queued.

cmsbuild · 2019-09-11T13:42:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d0c01/2479/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2957224
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2956882
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 145 log files, 15 edm output root files, 34 DQM output files

slava77 · 2019-09-11T20:24:25Z

the last commits changed mostly just the Trk clusters
Overall, since the last reco signoff for d58fa18 (to update #27819 (comment)) the Trk now look like

this is just to note the change in outputs.
The change in the code was already confirmed in #27819 (comment)

slava77 · 2019-09-11T20:26:14Z

+1

for #27819 1dc050c

code changes are in line with the PR description and the follow up review; including the bugfix in the eta range introduced since the last reco signoff
jenkins tests pass and comparisons with the baseline show no differences
local tests with ticl enabled show somewhat expected behavior (see notes from the last reco signoff, HGCAL: 1st version of hadronic reconstruction #27819 (comment), and HGCAL: 1st version of hadronic reconstruction #27819 (comment))

kpedro88 · 2019-09-11T20:27:12Z

+upgrade

cmsbuild · 2019-09-11T20:27:40Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

slava77 · 2019-09-11T20:33:19Z

the CPU time in TICL since #27819 (comment) (coming from the eta range fixes) increased almost twofold from 4.6 s to 8.3 s, which is still small compared to the rest of what's happening in PU200 reco.

rovere · 2019-09-12T06:46:55Z

@slava77 As I mentioned in a previous comment, the current timing could be easily reduced by half by doing proper masking (well, that will add the inference time into the game ;) ).

slava77 · 2019-09-12T13:48:36Z

@fabiocos
please check this, in hope that it can make it to pre8 as well.
Thank you.

fabiocos · 2019-09-12T14:09:29Z

@slava77 I've already noted it for integration this evening, thanks for warning me

fabiocos · 2019-09-12T20:01:53Z

+1

cmsbuild added this to the CMSSW_11_0_X milestone Aug 22, 2019

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels Aug 22, 2019

cmsbuild added code-checks-rejected and removed code-checks-pending labels Aug 22, 2019

cmsbuild added code-checks-pending and removed code-checks-rejected labels Aug 22, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 22, 2019

cmsbuild added tests-started and removed tests-pending labels Aug 22, 2019

cmsbuild removed the tests-started label Aug 22, 2019

cmsbuild added tests-started and removed tests-pending labels Sep 11, 2019

cmsbuild added tests-approved and removed tests-started labels Sep 11, 2019

cmsbuild added comparison-available and removed comparison-pending labels Sep 11, 2019

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Sep 11, 2019

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Sep 11, 2019

cmsbuild added orp-approved and removed orp-pending labels Sep 12, 2019

cmsbuild merged commit 7a0e60c into cms-sw:master Sep 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HGCAL: 1st version of hadronic reconstruction #27819

HGCAL: 1st version of hadronic reconstruction #27819

gouskos commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

felicepantaleo commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

slava77 commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

gouskos commented Aug 22, 2019

perrotta commented Aug 22, 2019

cmsbuild commented Aug 22, 2019 •

edited

Loading

clelange commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

cmsbuild commented Sep 11, 2019

felicepantaleo commented Sep 11, 2019

cmsbuild commented Sep 11, 2019 •

edited

Loading

cmsbuild commented Sep 11, 2019

cmsbuild commented Sep 11, 2019

cmsbuild commented Sep 11, 2019

slava77 commented Sep 11, 2019

slava77 commented Sep 11, 2019

kpedro88 commented Sep 11, 2019

cmsbuild commented Sep 11, 2019

slava77 commented Sep 11, 2019

rovere commented Sep 12, 2019

slava77 commented Sep 12, 2019

fabiocos commented Sep 12, 2019

fabiocos commented Sep 12, 2019

HGCAL: 1st version of hadronic reconstruction #27819

HGCAL: 1st version of hadronic reconstruction #27819

Conversation

gouskos commented Aug 22, 2019

PR description:

PR validation:

cmsbuild commented Aug 22, 2019

felicepantaleo commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

slava77 commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

gouskos commented Aug 22, 2019

perrotta commented Aug 22, 2019

cmsbuild commented Aug 22, 2019 • edited Loading

clelange commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

cmsbuild commented Sep 11, 2019

felicepantaleo commented Sep 11, 2019

cmsbuild commented Sep 11, 2019 • edited Loading

cmsbuild commented Sep 11, 2019

cmsbuild commented Sep 11, 2019

cmsbuild commented Sep 11, 2019

slava77 commented Sep 11, 2019

slava77 commented Sep 11, 2019

kpedro88 commented Sep 11, 2019

cmsbuild commented Sep 11, 2019

slava77 commented Sep 11, 2019

rovere commented Sep 12, 2019

slava77 commented Sep 12, 2019

fabiocos commented Sep 12, 2019

fabiocos commented Sep 12, 2019

cmsbuild commented Aug 22, 2019 •

edited

Loading

cmsbuild commented Sep 11, 2019 •

edited

Loading