-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix autoCondPhase2.py for python 3 #27810
Conversation
Python 3 dicts do not have iteritems method.
The code-checks are being triggered in jenkins. |
please test |
@davidlange6 this should fix most of the python 3 failures seen in the DEVEL IB. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27810/11518
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: Configuration/AlCa @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
isn't this the very same of #27805? |
Right - i randomly made the same pr earlier today:)
… On Aug 20, 2019, at 4:33 PM, Chris Jones ***@***.***> wrote:
@davidlange6 this should fix most of the python 3 failures seen in the DEVEL IB.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
There is also #27781 trying to fix the same issue... |
ha - indeed - i would proposed using this one or mine rather than #27781.
… On Aug 20, 2019, at 4:44 PM, Matti Kortelainen ***@***.***> wrote:
There is also #27781 trying to fix the same issue...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
This is a duplicate of #27805 |
PR description:
Python 3 dicts do not have iteritems method.
PR validation:
Using CMSSW_11_0_DEVEL_X_2019-08-18-2300 ran runTheMatrix.py -l 1.0 which now works (was failing in the IBs).