Properly veto HGCal superclusters from entering regular PFBlocks - phase2 scenarios #27785
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27785/11473
|
|
A new Pull Request was created by @hatakeyamak (Kenichi Hatakeyama) for master. It involves the following packages: RecoParticleFlow/PFProducer @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
I think the change is made as intended, but I don't quite understand some changes in btag and photons for phase2. Thinking... Any inputs will be appreciated. |
|
@hatakeyamak , was there any progress in it? Looking at the differences in the Phase2 workflows, there are less elements in the PFBlocks , which is exactly what this PR is intended to. Then this propagates into differences in other quantities like secondary vertices, impact parameters, which end up in the differences for photons and btag that you are mentioning. Is it really unexpected, due to the removal of those PFblocks from HGCal? |
|
assign upgrade |
|
New categories assigned: upgrade @kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
+upgrade |
Yes, I simply looked at the differences in the "comparison failed" section of the automatic tests results. The "reco comparison differences" looks at the differences between reco quantities in the root outputs. |
|
@hatakeyamak please either confirm that the changes observed in output look reasonable also to you, or just let us know when you think you can be done with your checks (and we'll put on hold this PR till then) |
|
Thanks for your ping @perrotta . I did some investigation on this for the last few days, and I think I am ready to sign this off. I still cannot fully connect this change to the changes in secondary vertices, but some changes in photons via changes in particleFlowEGamma resulting from intended changes in PFBlocks are clear. This PR is certainly doing the right thing for PFBlocks, so I think we can sign this off. Sorry that this took long. |
|
@cmsbuild please test to still have the test results available before merging |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
+1 |
PR description:
Fix vetoes of superclusters from HGCAL going into PFBlocks. As we set up the PF workflow now, we are keeping the endcap HGCAL part separate from the barrel and HF sections, and we don't want superclusters going into regular PFBlocks, but this vetoes was not implemented properly, causing many LogError messages.
This should also address issues reported here:
#22582
PR validation:
Compiles. Also made sure the superclusters from HGCAL are properly removed from PFBlocks in a phase2 matrix test 20434.0 (ttbar D41), while retaining superclusters from barrel.
if this PR is a backport please specify the original PR:
Not backport.
@bendavid @guitargeek @jpata @Sam-Harper (cannot find github name of newer egamma leaders...)