Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert TF changes on DEVEL #27710

Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Aug 7, 2019

PR description:

Reverts changes for tensorflow 1.13

PR validation:

Sources on master are the same, in theory should build as master builds
Building locally would require building the external AND the PR so better let the bot do it.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

A new Pull Request was created by @mrodozov (Mircho Rodozov) for CMSSW_11_0_DEVEL_X.

It involves the following packages:

DQMServices/Core
PhysicsTools/TensorFlow

@perrotta, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU, @slava77, @santocch can you please review it and eventually sign? Thanks.
@makortel, @barvic this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

mrodozov commented Aug 7, 2019

needs cms-sw/cmsdist#5141

@mrodozov
Copy link
Contributor Author

mrodozov commented Aug 7, 2019

please test with cms-sw/cmsdist#5141

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5141
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1872/console Started: 2019/08/07 16:47

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

-1

Tested at: dab137c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-901248/1872/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test materialBudgetTrackerPlots had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-901248/1872/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1418 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 2715989
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2715659
  • DQMHistoTests: Total skipped: 329
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@smuzaffar
Copy link
Contributor

we need to merge it for DEVEL IBs

@smuzaffar smuzaffar merged commit 87089bc into cms-sw:CMSSW_11_0_DEVEL_X Aug 7, 2019
@jfernan2
Copy link
Contributor

jfernan2 commented Jun 4, 2020

+1
For the records

@santocch
Copy link

+1

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_DEVEL_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants