L1TrackTrigger TTTrackmods CMSSW_10

[mdhildreth]

PR description:

Add digitized TTTrack variables to TTTrack class. Add new interfaces. Keep old interfaces for backwards compatibility.

PR validation:

Purely technical fixes. Old interfaces remain.

if this PR is a backport please specify the original PR:

Backport of 27686

[cmsbuild]

A new Pull Request was created by @mdhildreth for CMSSW_10_6_X.

It involves the following packages:

DQM/SiOuterTracker
DataFormats/L1TrackTrigger

@benkrikler, @kmaeshima, @schneiml, @andrius-k, @kpedro88, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@rovere, @sviret this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from L1 track trigger TTTrack mods #27686

[cmsbuild]

Pull request #27688 was updated. @benkrikler, @kmaeshima, @schneiml, @andrius-k, @kpedro88, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please check and sign again.

[mdhildreth]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1826/console Started: 2019/08/04 20:10

[cmsbuild]

+1
Tested at: 1546fb6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d9f5c/1826/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Pull request #27688 was updated. @benkrikler, @kmaeshima, @schneiml, @andrius-k, @kpedro88, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please check and sign again.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d9f5c/1826/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3208248
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3207912
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[mdhildreth]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1855/console Started: 2019/08/06 17:29

[cmsbuild]

+1
Tested at: 7daa87e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d9f5c/1855/summary.html

[cmsbuild]

Comparison job queued.

[mdhildreth]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2852/console Started: 2019/10/09 17:43

[cmsbuild]

+1
Tested at: c2292f3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d9f5c/2852/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d9f5c/2852/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212305
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211969
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[jfernan2]

+1

[mdhildreth]

@kpedro88 @fabiocos @rekovic I updated this backport to match the one previously put in the master branch. (With the same caveats of future cleanup once the L1 TDR is done.) Could you please sign off on this?

[kpedro88]

@mdhildreth is there a clear use case for this backport? Another round of production, user analysis, etc.?

[mdhildreth]

@kpedro88 My understanding is that the L1Track stuff is going to be used "post-production" on the 10_6 samples. So, it's just to have things close in release, rather than using CMSSW_11.

[kpedro88]

+upgrade

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1