Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clang headers location and changed interfaces #27663

Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Aug 1, 2019

PR description:

Adjusting to llvm8 interfaces

PR validation:

It compiles

if this PR is a backport please specify the original PR:

@cmsbuild cmsbuild added this to the CMSSW_11_0_X milestone Aug 1, 2019
@mrodozov
Copy link
Contributor Author

mrodozov commented Aug 1, 2019

please test with cms-sw/cmsdist#5114

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27663/11228

  • This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27663/11230

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

Utilities/StaticAnalyzers

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

mrodozov commented Aug 1, 2019

please test with cms-sw/cmsdist#5114

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5114
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1771/console Started: 2019/08/01 16:10

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 23, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5146
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2132/console Started: 2019/08/23 12:49

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8a5cb/2132/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939508
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2939165
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 142 log files, 14 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 26, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5146
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2200/console Started: 2019/08/27 00:00

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8a5cb/2200/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939508
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2939165
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

backport done
Successfully backported PR #27663 as #27877 for branch master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants