Fix for L1 EG emulation in 2018 HI

[christopheralanwest]

PR description:

The 103X 2018 HI MC GT contains an incorrect L1TCaloParams condition. To maintain consistency with the existing 103X HI samples, it was decided to not use a corrected 103X GT for new HI samples, but conditions in the development GT should be updated in case new HI samples for 2018 are ever generated in a future release.

Only the 2018 HI MC GT is changed and so differences in the comparison tests should only be seen in 2018 HI MC samples.

GT diff:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018_realistic_HI_v2/110X_upgrade2018_realistic_HI_v1

PR validation:

The payload validation was described in https://indico.cern.ch/event/829647/#4-updated-l1tcalo-conditions-f

A technical validation of the GT changes was performed: runTheMatrix.py -l limited -i all --ibeos

if this PR is a backport please specify the original PR:

This PR is not a backport and should not be backported.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27621/11072

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/AlCa/python/autoCond.py modified in PR(s): Activate Pixel Charge Reweighting for phase-0 detector (2016 only) #27600, Update ECAL conditions to provide correct reference for 2016 and 2018 UL #27604, Phase-2 InnerTracker conditions from DB (version 2) #27517, Adding Run 330098 (2019 MWGR3) in data relvals #27341

[cmsbuild]

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[christopheralanwest]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1657/console Started: 2019/07/26 14:57

[cmsbuild]

+1
Tested at: e24a2bc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9ce75/1657/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9ce75/1657/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2628546
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2628210
• DQMHistoTests: Total skipped: 317
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[christopheralanwest]

+1

• Payload has been verified in offline tests
• The only differences in the comparison tests are in L1 calorimeter quantities in the 2018 HI workflow

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1