Phase2-hgx205 Add a new scenario for HGCal V11 geometry version #27555

bsunanda · 2019-07-18T16:24:57Z

PR description:

Add a new scenario 2026D46 with V11 geometry version of HGCal. Also a new workflow 22034 is worked out

PR validation:

Tested with the new workflow

if this PR is a backport please specify the original PR:

No back porting is needed

cmsbuild · 2019-07-18T16:26:23Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-07-18T16:35:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27555/10948

This PR adds an extra 44KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Phase-2 InnerTracker conditions from DB (version 2) #27517, Add workflows for 2023 and 2024. Replace 13TeV 2021 by 14TeV. #27433

cmsbuild · 2019-07-18T16:36:16Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Configuration/Eras
Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData
L1Trigger/Configuration

@cmsbuild, @benkrikler, @Dr15Jones, @cvuosalo, @civanch, @ianna, @mdhildreth, @pgunnell, @rekovic, @franzoni, @kpedro88, @zhenhu, @prebello, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2019-07-18T16:38:00Z

@cmsbuild Please test

cmsbuild · 2019-07-18T16:38:57Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1531/console Started: 2019/07/18 19:09

kpedro88 · 2019-07-18T18:30:20Z

please abort

cmsbuild · 2019-07-18T18:30:46Z

Jenkins tests are aborted.

kpedro88 · 2019-07-18T18:31:01Z

please test workflow 22034.0

cmsbuild · 2019-07-18T18:31:17Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1532/console Started: 2019/07/18 20:31

cmsbuild · 2019-07-18T20:14:25Z

+1
Tested at: c45bd66
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b1287/1532/summary.html

cmsbuild · 2019-07-23T05:33:54Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b1287/1587/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-5b1287/22034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D46_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D46+RecoFullGlobal_2026D46+HARVESTFullGlobal_2026D46

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 2622600
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2622298
DQMHistoTests: Total skipped: 302
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

kpedro88 · 2019-07-23T15:26:03Z

+upgrade
new workflow runs, output logs look normal

bsunanda · 2019-07-24T13:32:13Z

@zhenhu, @prebello, @rekovic Please sign this PR

fabiocos · 2019-07-26T08:16:31Z

+operations

the update of Eras and geometry configurations is coherent with the purpose of the PR and appears correct

fabiocos · 2019-07-26T08:17:08Z

@zhenhu @prebello the update of PyRelVal looks ok and straightforward, please check and sign or comment

fabiocos · 2019-07-26T08:19:47Z

@rekovic the update of the L1 configuration looks a minimal update of the existing one, with a protection for the HGcal v11. Please check and sign it, I would like to merge this PR asap

fabiocos · 2019-07-27T21:00:40Z

@zhenhu @prebello I would like to move forward with this PR, could you please check it?

prebello · 2019-07-27T21:05:27Z

+1

I don't seem any problem with it

kpedro88 · 2019-07-30T13:12:52Z

@rekovic @benkrikler please check and sign

kpedro88 · 2019-07-30T21:42:41Z

+1

kpedro88 · 2019-07-30T21:42:56Z

merge

slava77 · 2019-07-31T19:46:59Z

Configuration/PyReleaseValidation/scripts/runTheMatrix.py

@@ -78,6 +78,7 @@ def runSelected(opt):
                     20034.0, #2026D35 ttbar (MTD TDR baseline)
                     20434.0, #2026D41 ttbar (L1T TDR baseline)
                     21234.0, #2026D44 (exercise HF nose)
+                     22034.0, #2026D46 ttbar (exercise V11 HGCal)


@kpedro88
can we consolidate some of the exercise this and that workflows some time soon?

If we were going to remove one right now, it would probably be D35. At some point, D44 will be replaced with a new version of the HF nose based on D46. But with different geometries that imply code changes, I am reluctant to remove them from regular tests, because things easily break (as we have seen in the past). I agree that we should try not to exceed the current number of workflows (4) if possible.

slava77 · 2019-07-31T20:47:15Z

Configuration/Geometry/README.md

@@ -12,6 +12,7 @@ Calorimeters:
 * C4: HGCal (v9) + Phase2 HCAL and EB
 * C6: HGCal (v9) + HFNose + Phase2 HCAL and EB
 * C8: HGCal (v10 post TDR HGCal Geometry) + Phase2 HCAL and EB + Tracker cables in calorimeter region
+* C9: HGCal (v11 post TDR HGCal Geometry same as V8 + corner centering for HE part)


did it really mean to say "same as V8" (C3 defined in 2016), or was it supposed to say "same as C8"?

I think it should be C8. @bsunanda ?

Yes it should be C8 - I shall correct this when I make the new PR with updated HGCal with HFNose

Add a new scenario for HGCal V11 geometry version

c45bd66

cmsbuild added this to the CMSSW_11_0_X milestone Jul 18, 2019

cmsbuild added code-checks-pending comparison-pending geometry-pending l1-pending operations-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Jul 18, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 18, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 18, 2019

cmsbuild added tests-pending and removed tests-started labels Jul 18, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 18, 2019

cmsbuild added the tests-approved label Jul 23, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jul 23, 2019

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 23, 2019

cmsbuild added operations-approved and removed operations-pending labels Jul 26, 2019

cmsbuild added pdmv-approved and removed pdmv-pending labels Jul 27, 2019

This was referenced Jul 29, 2019

Light by light modifier 1100 pre1 #27633

Merged

DD: Replace PseudoTrap shape by TruncTubs #27632

Merged

Phase-2 InnerTracker conditions from DB (version 2) #27517

Merged

cmsbuild added orp-approved and removed orp-pending labels Jul 30, 2019

cmsbuild merged commit b4e9a4f into cms-sw:master Jul 30, 2019

bsunanda deleted the Phase2-hgx205 branch July 30, 2019 21:49

slava77 reviewed Jul 31, 2019

View reviewed changes

slava77 mentioned this pull request Jul 31, 2019

reco comparisons: add a maping for D46, only for ttbar wf 22034 cms-sw/cms-bot#1179

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-hgx205 Add a new scenario for HGCal V11 geometry version #27555

Phase2-hgx205 Add a new scenario for HGCal V11 geometry version #27555

bsunanda commented Jul 18, 2019

cmsbuild commented Jul 18, 2019

cmsbuild commented Jul 18, 2019

cmsbuild commented Jul 18, 2019

bsunanda commented Jul 18, 2019

cmsbuild commented Jul 18, 2019 •

edited

Loading

kpedro88 commented Jul 18, 2019

cmsbuild commented Jul 18, 2019

kpedro88 commented Jul 18, 2019

cmsbuild commented Jul 18, 2019 •

edited

Loading

cmsbuild commented Jul 18, 2019

cmsbuild commented Jul 23, 2019

kpedro88 commented Jul 23, 2019

bsunanda commented Jul 24, 2019

fabiocos commented Jul 26, 2019

fabiocos commented Jul 26, 2019

fabiocos commented Jul 26, 2019

fabiocos commented Jul 27, 2019

prebello commented Jul 27, 2019

kpedro88 commented Jul 30, 2019

kpedro88 commented Jul 30, 2019

kpedro88 commented Jul 30, 2019

slava77 Jul 31, 2019

kpedro88 Jul 31, 2019

slava77 Jul 31, 2019

kpedro88 Jul 31, 2019

bsunanda Jul 31, 2019

Phase2-hgx205 Add a new scenario for HGCal V11 geometry version #27555

Phase2-hgx205 Add a new scenario for HGCal V11 geometry version #27555

Conversation

bsunanda commented Jul 18, 2019

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Jul 18, 2019

cmsbuild commented Jul 18, 2019

cmsbuild commented Jul 18, 2019

bsunanda commented Jul 18, 2019

cmsbuild commented Jul 18, 2019 • edited Loading

kpedro88 commented Jul 18, 2019

cmsbuild commented Jul 18, 2019

kpedro88 commented Jul 18, 2019

cmsbuild commented Jul 18, 2019 • edited Loading

cmsbuild commented Jul 18, 2019

cmsbuild commented Jul 23, 2019

kpedro88 commented Jul 23, 2019

bsunanda commented Jul 24, 2019

fabiocos commented Jul 26, 2019

fabiocos commented Jul 26, 2019

fabiocos commented Jul 26, 2019

fabiocos commented Jul 27, 2019

prebello commented Jul 27, 2019

kpedro88 commented Jul 30, 2019

kpedro88 commented Jul 30, 2019

kpedro88 commented Jul 30, 2019

slava77 Jul 31, 2019

Choose a reason for hiding this comment

kpedro88 Jul 31, 2019

Choose a reason for hiding this comment

slava77 Jul 31, 2019

Choose a reason for hiding this comment

kpedro88 Jul 31, 2019

Choose a reason for hiding this comment

bsunanda Jul 31, 2019

Choose a reason for hiding this comment

cmsbuild commented Jul 18, 2019 •

edited

Loading

cmsbuild commented Jul 18, 2019 •

edited

Loading