DD4hep: Ecal Preshower Algorithm Migration #27518

ianna · 2019-07-14T13:17:38Z

PR description:

DDEcalPreshowerAlgo migrated to DD4hep ASIS

Note: The PR is based on #27501

PR validation:

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

* Code format

cmsbuild · 2019-07-14T13:18:08Z

The code-checks are being triggered in jenkins.

ianna · 2019-07-14T13:18:35Z

please test

cmsbuild · 2019-07-14T13:26:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27518/10877

This PR adds an extra 80KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DetectorDescription/DDCMS/data/testPosParts.xml modified in PR(s): DD4hep: Ecal Endcap Algo #27501
- File DetectorDescription/DDCMS/data/testRotations.xml modified in PR(s): DD4hep: Ecal Endcap Algo #27501
- File DetectorDescription/DDCMS/interface/DDXMLTags.h modified in PR(s): DD4hep: Ecal Endcap Algo #27501
- File DetectorDescription/DDCMS/plugins/DDDefinitions2Objects.cc modified in PR(s): DD4hep: Ecal Endcap Algo #27501
- File DetectorDescription/DDCMS/src/DDAlgoArguments.cc modified in PR(s): DD4hep: Ecal Endcap Algo #27501
- File Geometry/EcalCommonData/data/dd4hep/cms-ecal-geometry.xml modified in PR(s): rename 2023 -> 2026, fix bug in D44 #27488, DD4hep: Ecal Endcap Algo #27501
- File Geometry/EcalCommonData/interface/DDEcalEndcapTrap.h modified in PR(s): DD4hep: Ecal Endcap Algo #27501
- File Geometry/EcalCommonData/plugins/DDEcalEndcapAlgo.cc modified in PR(s): DD4hep: Ecal Endcap Algo #27501
- File Geometry/EcalCommonData/plugins/dd4hep/DDEcalBarrelNewAlgo.cc modified in PR(s): DD4hep: Ecal Endcap Algo #27501
- File Geometry/EcalCommonData/plugins/dd4hep/DDEcalEndcapAlgo.cc modified in PR(s): DD4hep: Ecal Endcap Algo #27501
- File Geometry/EcalCommonData/src/DDEcalEndcapTrap.cc modified in PR(s): DD4hep: Ecal Endcap Algo #27501

cmsbuild · 2019-07-14T13:27:02Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1465/console Started: 2019/07/14 16:08

cmsbuild · 2019-07-14T13:27:03Z

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS
Geometry/EcalCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2019-07-14T16:18:52Z

+1
Tested at: 91936c1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4c6aa/1465/summary.html

cmsbuild · 2019-07-14T16:18:55Z

Comparison job queued.

cmsbuild · 2019-07-14T18:44:19Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4c6aa/1465/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3081858
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3081534
DQMHistoTests: Total skipped: 322
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

ianna · 2019-07-14T20:46:34Z

+1

cmsbuild · 2019-07-16T13:08:11Z

The code-checks are being triggered in jenkins.

ianna · 2019-07-16T13:08:28Z

@ianna this PR does not remove all references to 2023 files in the xml:

cmssw/Geometry/EcalCommonData/data/dd4hep/cms-ecal-geometry.xml

Lines 44 to 45 in f471ffb

<Include ref='Geometry/CMSCommonData/data/beampipe/2023/v1/beampipe.xml'/>

<Include ref='Geometry/CMSCommonData/data/cmsBeam/2023/v1/cmsBeam.xml'/>

@kpedro88 - the dependency is removed

ianna · 2019-07-16T13:08:48Z

please test

cmsbuild · 2019-07-16T13:17:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27518/10904

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/EcalCommonData/data/dd4hep/cms-ecal-geometry.xml modified in PR(s): rename 2023 -> 2026, fix bug in D44 #27488

cmsbuild · 2019-07-16T13:18:22Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1487/console Started: 2019/07/16 15:18

cmsbuild · 2019-07-16T13:18:24Z

Pull request #27518 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

fabiocos · 2019-07-16T13:51:58Z

@ianna thanks, as this is a test configuration I understand the change should not be an issue in itself right?

ianna · 2019-07-16T14:32:39Z

@ianna thanks, as this is a test configuration I understand the change should not be an issue in itself right?

no, it's not an issue as long as the PR does not get delayed by the changes elsewhere.

cmsbuild · 2019-07-16T15:18:55Z

+1
Tested at: 7a75825
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4c6aa/1487/summary.html

cmsbuild · 2019-07-16T15:18:59Z

Comparison job queued.

cmsbuild · 2019-07-16T17:59:36Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4c6aa/1487/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3081858
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3081534
DQMHistoTests: Total skipped: 322
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

ianna · 2019-07-16T20:36:46Z

+1

cmsbuild · 2019-07-16T20:37:13Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-07-17T08:54:20Z

+1

ianna added 5 commits July 14, 2019 10:06

Ecal endcap algo

e1b678d

* Workaround for reflection rotation

93cbcb9

* Code format

code checks

cb03023

Ecal preshower algorithm migration

32c2d58

code format

91936c1

cmsbuild added this to the CMSSW_11_0_X milestone Jul 14, 2019

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending labels Jul 14, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 14, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 14, 2019

cmsbuild added tests-approved and removed tests-started labels Jul 14, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jul 14, 2019

cmsbuild removed the code-checks-approved label Jul 14, 2019

Merge branch 'master' into dd4hep-ecal-preshower-algo-v1

7a75825

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 16, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 16, 2019

cmsbuild added tests-approved and removed tests-started labels Jul 16, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jul 16, 2019

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Jul 16, 2019

cmsbuild added orp-approved and removed orp-pending labels Jul 17, 2019

cmsbuild merged commit f46916d into cms-sw:master Jul 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DD4hep: Ecal Preshower Algorithm Migration #27518

DD4hep: Ecal Preshower Algorithm Migration #27518

ianna commented Jul 14, 2019 •

edited

Loading

cmsbuild commented Jul 14, 2019

ianna commented Jul 14, 2019

cmsbuild commented Jul 14, 2019

cmsbuild commented Jul 14, 2019 •

edited

Loading

cmsbuild commented Jul 14, 2019

cmsbuild commented Jul 14, 2019

cmsbuild commented Jul 14, 2019

cmsbuild commented Jul 14, 2019

ianna commented Jul 14, 2019

cmsbuild commented Jul 16, 2019

ianna commented Jul 16, 2019

ianna commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

cmsbuild commented Jul 16, 2019 •

edited

Loading

cmsbuild commented Jul 16, 2019

fabiocos commented Jul 16, 2019

ianna commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

ianna commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

fabiocos commented Jul 17, 2019

DD4hep: Ecal Preshower Algorithm Migration #27518

DD4hep: Ecal Preshower Algorithm Migration #27518

Conversation

ianna commented Jul 14, 2019 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Jul 14, 2019

ianna commented Jul 14, 2019

cmsbuild commented Jul 14, 2019

cmsbuild commented Jul 14, 2019 • edited Loading

cmsbuild commented Jul 14, 2019

cmsbuild commented Jul 14, 2019

cmsbuild commented Jul 14, 2019

cmsbuild commented Jul 14, 2019

ianna commented Jul 14, 2019

cmsbuild commented Jul 16, 2019

ianna commented Jul 16, 2019

ianna commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

cmsbuild commented Jul 16, 2019 • edited Loading

cmsbuild commented Jul 16, 2019

fabiocos commented Jul 16, 2019

ianna commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

ianna commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

fabiocos commented Jul 17, 2019

ianna commented Jul 14, 2019 •

edited

Loading

cmsbuild commented Jul 14, 2019 •

edited

Loading

cmsbuild commented Jul 16, 2019 •

edited

Loading